ruby-core

> |Looks fine to me, but I wonder if both are necessary, have_bin
> |seems to work good enough even if it were an alias of find_bin.
> 
> I feel like "bin" in have_bin and find_bin (BTW, why both?) is better
> to be replaced by "executable".

executable works for me, I can update the patch.  The reason for both
was to keep inline with the style of having both find and have.  I
suppose you could alias them.  Anyway, I've included a slightly
updated patch that allows a user to specify a path.  If adding an
alias is important for API's sake, it's very possible to do.  :~) -sc

-- 
Sean Chittenden

Attachments (1)

patch (857 Bytes, text/x-diff)

Index: lib/mkmf.rb
===================================================================
RCS file: /src/ruby/lib/mkmf.rb,v
retrieving revision 1.87
diff -u -r1.87 mkmf.rb
--- lib/mkmf.rb	2002/06/28 14:42:46	1.87
+++ lib/mkmf.rb	2002/08/14 18:09:19
@@ -351,6 +351,30 @@
   return true
 end
 
+def find_executable(bin, path = nil)
+  printf "checking for %s... ", bin
+  STDOUT.flush
+
+  if path.nil?
+    path = ENV['PATH'].split(Config::CONFIG['PATH_SEPARATOR'])
+  else
+    path = path.split(Config::CONFIG['PATH_SEPARATOR'])
+  end
+ 
+  bin += Config::CONFIG['EXEEXT']
+  for dir in path
+    file = File.join(dir, bin)
+    if FileTest.executable?(file)
+      print "yes\n"
+      return file
+    else
+      next
+    end
+  end
+  print "no\n"
+  return nil
+end
+
 def arg_config(config, default=nil)
   $configure_args.fetch(config, default)
 end

Thread

Prev Next

In This Thread

Prev Next

[#290] — Florian Frank <flori@...>

[#291] Kernel Thread implementation — Matthew Bloch <mattbee@...>

[#297] GC longjmp macros — Michal Rokos <m.rokos@...>

[#298] Is there a bug in Matrix or Complex? — Jim Freeze <jim@...>

[#308] Q: OSSL in std. distr? — Michal Rokos <m.rokos@...>

[#309] Progress on incremental GC? — "Timothy J. Wood" <tjw@...>

[#314] resolv.rb on 1.6.7 — Dave Thomas <Dave@...>

[#316] Embeding Ruby in C++ code. — Kostas Katsamakas <kmak@...>

[#318] C and Ruby... — Kostas Katsamakas <kmak@...>

[#321] Ruby module, Warn(ing) interface — Michal Rokos <m.rokos@...>

[#326] Implications of a #force_free method in Object? — Matthew Bloch <mattbee@...>

[#328] Int vs Long — Michal Rokos <m.rokos@...>

[#329] Int vs Long #2 — Michal Rokos <m.rokos@...>

[#337] Int vs Long (2nd part) — Michal Rokos <m.rokos@...>

[#340] Int vs Long #3 — Michal Rokos <m.rokos@...>

[#345] Bug in gc.c or misunderstanding on my part? — "Timothy J. Wood" <tjw@...>

[#349] Array#select — Michal Rokos <m.rokos@...>

[#353] File (struct stat handling) — Michal Rokos <m.rokos@...>

[#355] Array and .*ALLOC.* changes — Michal Rokos <m.rokos@...>

[#358] node.h for eval.c — Michal Rokos <m.rokos@...>

[#363] Ruby embedding limitations — "Timothy J. Wood" <tjw@...>

[#367] RE: Welcome to our (ruby-core ML) You are added automatically — Girish Sharangpani <girishs@...>

[#372] rb_class_path — Michal Rokos <m.rokos@...>

[#376] Virtual host and port number in CGI — Raymond Blum <raymond@...>

[#382] Port match to new dup, clone framework — Michal Rokos <m.rokos@...>

[#387] rb_str_replace — Michal Rokos <m.rokos@...>

[#392] io.c read_all — Michal Rokos <m.rokos@...>

[#393] in dln.c — Michal Rokos <m.rokos@...>

[#394] in file.c — Michal Rokos <m.rokos@...>

[#395] CVS version and win32 naming — "Rich Kilmer" <rich@...>

Re: [PATCH] lib/mkmf.rb: have_bin()/find_bin()

Attachments (1)

Thread

In This Thread

[#355] Array and .ALLOC. changes — Michal Rokos <m.rokos@...>