[#290] — Florian Frank <flori@...>
Hi all,
5 messages
2002/08/03
[#297] GC longjmp macros — Michal Rokos <m.rokos@...>
Hi,
5 messages
2002/08/05
[#308] Q: OSSL in std. distr? — Michal Rokos <m.rokos@...>
Hi,
4 messages
2002/08/08
[#326] Implications of a #force_free method in Object? — Matthew Bloch <mattbee@...>
Hello;
8 messages
2002/08/19
[#328] Int vs Long — Michal Rokos <m.rokos@...>
Hi,
7 messages
2002/08/21
[#337] Int vs Long (2nd part) — Michal Rokos <m.rokos@...>
Hi,
7 messages
2002/08/22
[#340] Int vs Long #3 — Michal Rokos <m.rokos@...>
Hi,
9 messages
2002/08/22
[#344] Re: [Cleanup] Int vs Long #3
— nobu.nokada@...
2002/08/22
Hi,
[#348] Re: [Cleanup] Int vs Long #3
— Michal Rokos <m.rokos@...>
2002/08/23
Hello,
[#353] File (struct stat handling) — Michal Rokos <m.rokos@...>
Hello,
6 messages
2002/08/23
[#358] node.h for eval.c — Michal Rokos <m.rokos@...>
Hi,
5 messages
2002/08/23
[#372] rb_class_path — Michal Rokos <m.rokos@...>
Hello,
7 messages
2002/08/27
[#382] Port match to new dup, clone framework — Michal Rokos <m.rokos@...>
Hi,
5 messages
2002/08/28
[#393] in dln.c — Michal Rokos <m.rokos@...>
Hi,
14 messages
2002/08/30
[#398] Re: [MemLeak] in dln.c
— nobu.nokada@...
2002/08/31
Hi,
[#403] Re: [MemLeak] in dln.c
— Michal Rokos <m.rokos@...>
2002/09/02
Hello,
Re: [Cleanup?] File (struct stat handling)
From:
nobu.nokada@...
Date:
2002-08-23 14:52:40 UTC
List:
ruby-core #356
Hi,
At Fri, 23 Aug 2002 21:56:02 +0900,
Michal Rokos wrote:
> @@ -2024,12 +2028,11 @@ rb_stat_clone(obj)
>
> clone = rb_obj_alloc(RBASIC(obj)->klass);
> CLONESETUP(clone,obj);
> +
> if (DATA_PTR(obj)) {
> nst = ALLOC(struct stat);
> - *nst = *(struct stat*)DATA_PTR(obj);
> - DATA_PTR(clone) = nst;
> + memcpy(DATA_PTR(clone), DATA_PTR(obj), sizeof(struct stat));
> }
> -
> return clone;
> }
Since File::Stat.allocate doesn't initialize DATA_PTR, this
change causes SEGV, and also memory leak.
> PS: Don't worry - no more patches are comming (It's weekend and
> BankHoliday monday) :-)
Don't mind, here is ruby-cleanup ML :-).
--
Nobu Nakada