ruby-core

Hi all,

some methods of File::Stat return 0 if the underlying feature isn't
supported on the target platform. Wouldn't it be nice if they returned
nil? With nil it would be possible to use the idiomatic
	size = stat.blksize || 4096
to give a default value without first checking if blksize is 0.

This would avert the danger to use the 0 values and overlook the fact
that they don't make any sense on those platforms as well. I have
attached a patch to be applied if you consider this changes ok.

-- 
WAR IS PEACE FREEDOM IS SLAVERY IGNORANCE IS STRENGTH.
  -- George Orwell, "1984", 1948

Attachments (1)

file.diff (1.1 KB, text/x-diff)

Index: file.c
===================================================================
RCS file: /src/ruby/file.c,v
retrieving revision 1.102
diff -u -p -u -r1.102 file.c
--- file.c	2002/06/11 01:27:46	1.102
+++ file.c	2002/08/03 00:31:13
@@ -214,7 +214,7 @@ rb_stat_rdev(self)
 #ifdef HAVE_ST_RDEV
     return ULONG2NUM(get_stat(self)->st_rdev);
 #else
-    return INT2FIX(0);
+    return Qnil;
 #endif
 }
 
@@ -226,7 +226,7 @@ rb_stat_rdev_major(self)
     long rdev = get_stat(self)->st_rdev;
     return ULONG2NUM(major(rdev));
 #else
-    return INT2FIX(0);
+    return Qnil;
 #endif
 }
 
@@ -238,7 +238,7 @@ rb_stat_rdev_minor(self)
     long rdev = get_stat(self)->st_rdev;
     return ULONG2NUM(minor(rdev));
 #else
-    return INT2FIX(0);
+    return Qnil;
 #endif
 }
 
@@ -256,7 +256,7 @@ rb_stat_blksize(self)
 #ifdef HAVE_ST_BLKSIZE
     return ULONG2NUM(get_stat(self)->st_blksize);
 #else
-    return INT2FIX(0);
+    return Qnil;
 #endif
 }
 
@@ -267,7 +267,7 @@ rb_stat_blocks(self)
 #ifdef HAVE_ST_BLOCKS
     return ULONG2NUM(get_stat(self)->st_blocks);
 #else
-    return INT2FIX(0);
+    return Qnil;
 #endif
 }

Thread

Prev Next

In This Thread

Prev Next

[#290] — Florian Frank <flori@...>

[#291] Kernel Thread implementation — Matthew Bloch <mattbee@...>

[#297] GC longjmp macros — Michal Rokos <m.rokos@...>

[#298] Is there a bug in Matrix or Complex? — Jim Freeze <jim@...>

[#308] Q: OSSL in std. distr? — Michal Rokos <m.rokos@...>

[#309] Progress on incremental GC? — "Timothy J. Wood" <tjw@...>

[#314] resolv.rb on 1.6.7 — Dave Thomas <Dave@...>

[#316] Embeding Ruby in C++ code. — Kostas Katsamakas <kmak@...>

[#318] C and Ruby... — Kostas Katsamakas <kmak@...>

[#321] Ruby module, Warn(ing) interface — Michal Rokos <m.rokos@...>

[#326] Implications of a #force_free method in Object? — Matthew Bloch <mattbee@...>

[#328] Int vs Long — Michal Rokos <m.rokos@...>

[#329] Int vs Long #2 — Michal Rokos <m.rokos@...>

[#337] Int vs Long (2nd part) — Michal Rokos <m.rokos@...>

[#340] Int vs Long #3 — Michal Rokos <m.rokos@...>

[#345] Bug in gc.c or misunderstanding on my part? — "Timothy J. Wood" <tjw@...>

[#349] Array#select — Michal Rokos <m.rokos@...>

[#353] File (struct stat handling) — Michal Rokos <m.rokos@...>

[#355] Array and .*ALLOC.* changes — Michal Rokos <m.rokos@...>

[#358] node.h for eval.c — Michal Rokos <m.rokos@...>

[#363] Ruby embedding limitations — "Timothy J. Wood" <tjw@...>

[#367] RE: Welcome to our (ruby-core ML) You are added automatically — Girish Sharangpani <girishs@...>

[#372] rb_class_path — Michal Rokos <m.rokos@...>

[#376] Virtual host and port number in CGI — Raymond Blum <raymond@...>

[#382] Port match to new dup, clone framework — Michal Rokos <m.rokos@...>

[#387] rb_str_replace — Michal Rokos <m.rokos@...>

[#392] io.c read_all — Michal Rokos <m.rokos@...>

[#393] in dln.c — Michal Rokos <m.rokos@...>

[#394] in file.c — Michal Rokos <m.rokos@...>

[#395] CVS version and win32 naming — "Rich Kilmer" <rich@...>

Attachments (1)

Thread

In This Thread

[#355] Array and .ALLOC. changes — Michal Rokos <m.rokos@...>