ruby-core

Hi,

	thanks for review.

On Fri, Aug 23, 2002 at 12:01:13AM +0900, nobu.nokada@softhome.net wrote:
> > @@ -1464,12 +1463,12 @@
> >      }
> >      len *= RARRAY(ary)->len;
> >  
> > -    ary2 = ary_new(rb_obj_class(ary), len);
> > -    RARRAY(ary2)->len = len;
> > +    ary2 = rb_ary_new2(len);
> 
> This changes semantics.

	OK, I will drop this one.

> rb_ary_new() doesn't take any arguments.  I guess you intended
> rb_ary_new2().

	Oops, I'll fix it.

> 
> > @@ -1690,14 +1685,16 @@
> >  rb_ary_uniq_bang(ary)
> >      VALUE ary;
> >  {
> > -    VALUE hash = ary_make_hash(ary, 0);
> > +    VALUE hash;
> >      VALUE *p, *q, *end;
> >  
> > +    rb_ary_modify(ary); 
> > +
> > +    hash = ary_make_hash(ary, 0);
> > +
> 
> Which should be done first?

	I hope this one (not the current) is the right one.

		Michal

-- 
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Michal Rokos                         Czech Technical University, Prague
E-mail:m.rokos@sh.cvut.cz      ICQ:36118339      Jabber:majkl@jabber.cz
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

Thread

Prev Next

In This Thread

Prev Next

[#290] — Florian Frank <flori@...>

[#291] Kernel Thread implementation — Matthew Bloch <mattbee@...>

[#297] GC longjmp macros — Michal Rokos <m.rokos@...>

[#298] Is there a bug in Matrix or Complex? — Jim Freeze <jim@...>

[#308] Q: OSSL in std. distr? — Michal Rokos <m.rokos@...>

[#309] Progress on incremental GC? — "Timothy J. Wood" <tjw@...>

[#314] resolv.rb on 1.6.7 — Dave Thomas <Dave@...>

[#316] Embeding Ruby in C++ code. — Kostas Katsamakas <kmak@...>

[#318] C and Ruby... — Kostas Katsamakas <kmak@...>

[#321] Ruby module, Warn(ing) interface — Michal Rokos <m.rokos@...>

[#326] Implications of a #force_free method in Object? — Matthew Bloch <mattbee@...>

[#328] Int vs Long — Michal Rokos <m.rokos@...>

[#329] Int vs Long #2 — Michal Rokos <m.rokos@...>

[#337] Int vs Long (2nd part) — Michal Rokos <m.rokos@...>

[#340] Int vs Long #3 — Michal Rokos <m.rokos@...>

[#345] Bug in gc.c or misunderstanding on my part? — "Timothy J. Wood" <tjw@...>

[#349] Array#select — Michal Rokos <m.rokos@...>

[#353] File (struct stat handling) — Michal Rokos <m.rokos@...>

[#355] Array and .*ALLOC.* changes — Michal Rokos <m.rokos@...>

[#358] node.h for eval.c — Michal Rokos <m.rokos@...>

[#363] Ruby embedding limitations — "Timothy J. Wood" <tjw@...>

[#367] RE: Welcome to our (ruby-core ML) You are added automatically — Girish Sharangpani <girishs@...>

[#372] rb_class_path — Michal Rokos <m.rokos@...>

[#376] Virtual host and port number in CGI — Raymond Blum <raymond@...>

[#382] Port match to new dup, clone framework — Michal Rokos <m.rokos@...>

[#387] rb_str_replace — Michal Rokos <m.rokos@...>

[#392] io.c read_all — Michal Rokos <m.rokos@...>

[#393] in dln.c — Michal Rokos <m.rokos@...>

[#394] in file.c — Michal Rokos <m.rokos@...>

[#395] CVS version and win32 naming — "Rich Kilmer" <rich@...>

Re: [Cleanup] Int vs Long (2nd part)

Thread

In This Thread

[#355] Array and .ALLOC. changes — Michal Rokos <m.rokos@...>