From: Michal Rokos <m.rokos@...>
Date: 2002-08-23T00:57:43+09:00
Subject: Re: [Cleanup] Int vs Long (2nd part)

Hi,

	thanks for review.

On Fri, Aug 23, 2002 at 12:01:13AM +0900, nobu.nokada@softhome.net wrote:
> > @@ -1464,12 +1463,12 @@
> >      }
> >      len *= RARRAY(ary)->len;
> >  
> > -    ary2 = ary_new(rb_obj_class(ary), len);
> > -    RARRAY(ary2)->len = len;
> > +    ary2 = rb_ary_new2(len);
> 
> This changes semantics.

	OK, I will drop this one.

> rb_ary_new() doesn't take any arguments.  I guess you intended
> rb_ary_new2().

	Oops, I'll fix it.

> 
> > @@ -1690,14 +1685,16 @@
> >  rb_ary_uniq_bang(ary)
> >      VALUE ary;
> >  {
> > -    VALUE hash = ary_make_hash(ary, 0);
> > +    VALUE hash;
> >      VALUE *p, *q, *end;
> >  
> > +    rb_ary_modify(ary); 
> > +
> > +    hash = ary_make_hash(ary, 0);
> > +
> 
> Which should be done first?

	I hope this one (not the current) is the right one.

		Michal

-- 
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Michal Rokos                         Czech Technical University, Prague
E-mail:m.rokos@sh.cvut.cz      ICQ:36118339      Jabber:majkl@jabber.cz
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-