Re: [Update] Port match to new dup, clone framework

From: Michal Rokos <m.rokos@...>
Date: 2002-08-28 15:37:20 UTC
List: ruby-core #386
Hello,

On Thu, Aug 29, 2002 at 12:18:49AM +0900, nobu.nokada@softhome.net wrote:
> You mean this? ;-)
>   /(.*)/=~"foo"; $~.become(Regexp.allocate)
> will leak memory.

	I knew that you will definitely find some bug in it. (Shame on
	me! I should definitely think more or upgrade my dead brain :-)
	
> > -    re_copy_registers(clone->regs, RMATCH(match)->regs);
>   +    if (obj == orig) return obj;
> > +    RMATCH(obj)->str = RMATCH(orig)->str;
>   +    re_free_registers(RMATCH(obj)->regs);
> > +    RMATCH(obj)->regs->allocated = 0;
> > +    re_copy_registers(RMATCH(obj)->regs, RMATCH(orig)->regs);

	Is it OK to commit patch with these changes?

		Michal

-- 
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Michal Rokos                         Czech Technical University, Prague
E-mail:m.rokos@sh.cvut.cz      ICQ:36118339      Jabber:majkl@jabber.cz
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

In This Thread