ruby-dev

前田です。

safe levelが4の時に例外が発生すると無限ループに陥いります。
これはrb_exc_newでrb_iv_setを呼ぶ時に例外が発生し、再びrb_exc_newが
呼ばれるためです。

safe levelが4の時に!tainted?なオブジェクトに対して変更が許されなくな
っているせいなのですが、これは制限がきつすぎないでしょうか。
変更された時にtaintするくらいでよいように思います。


-- 
前田 修吾 (mailto:shugo@aianet.ne.jp)

Attachments (1)

ruby.diff (1.58 KB, text/x-diff)

--- array.c.orig	Wed Nov 25 12:31:09 1998
+++ array.c	Fri Dec 25 00:46:05 1998
@@ -48,7 +48,7 @@
     if (FL_TEST(ary, ARY_FREEZE|ARY_TMPLOCK))
 	rb_raise(rb_eTypeError, "can't modify frozen array");
     if (rb_safe_level() >= 4 && !FL_TEST(ary, FL_TAINT))
-	rb_raise(rb_eSecurityError, "Insecure: can't modify array");
+	rb_obj_taint(ary);
 }
 
 VALUE
--- hash.c.orig	Tue Dec 22 18:01:51 1998
+++ hash.c	Fri Dec 25 00:46:05 1998
@@ -31,7 +31,7 @@
     if (FL_TEST(hash, HASH_FREEZE))
 	rb_raise(rb_eTypeError, "can't modify frozen hash");
     if (rb_safe_level() >= 4 && !FL_TEST(hash, FL_TAINT))
-	rb_raise(rb_eSecurityError, "Insecure: can't modify hash");
+	rb_obj_taint(hash);
 }
 
 VALUE
--- string.c.orig	Thu Dec 24 13:39:55 1998
+++ string.c	Fri Dec 25 00:46:05 1998
@@ -354,7 +354,7 @@
     if (FL_TEST(str, STR_FREEZE))
 	rb_raise(rb_eTypeError, "can't modify frozen string");
     if (rb_safe_level() >= 4 && !FL_TEST(str, FL_TAINT))
-	rb_raise(rb_eSecurityError, "Insecure: can't modify string");
+	rb_obj_taint(str);
     if (!RSTRING(str)->orig || FL_TEST(str, STR_NO_ORIG)) return;
     ptr = RSTRING(str)->ptr;
     RSTRING(str)->ptr = ALLOC_N(char, RSTRING(str)->len+1);
--- variable.c.orig	Thu Dec 24 14:08:47 1998
+++ variable.c	Fri Dec 25 00:46:05 1998
@@ -851,7 +851,7 @@
       case T_MODULE:
       case T_FILE:
 	if (rb_safe_level() >= 4 && !FL_TEST(obj, FL_TAINT))
-	    rb_raise(rb_eSecurityError, "Insecure: can't modify instance variable");
+	    rb_obj_taint(obj);
 	if (!ROBJECT(obj)->iv_tbl) ROBJECT(obj)->iv_tbl = st_init_numtable();
 	st_insert(ROBJECT(obj)->iv_tbl, id, val);
 	break;

Thread

Prev Next

In This Thread

Prev Next

[#3726] str_new — ttate@...

[#3731] Re: [ruby-list:11138] Re: 拡張モジュールの Makefile — Motoyuki Kasahara <m-kasahr@...>

[#3733] Re: about ext/{tk,tcltklib}/Makefile — WATANABE Hirofumi <watanabe@...>

[#3747] constants (or class vriable?) — Wakou Aoyama <wakou@...>

[#3749] Error message in dln.c(Win32) — WATANABE Hirofumi <watanabe@...>

[#3773] pack("M")/unpack("M") — shugo@... (MAEDA Shugo)

[#3794] port NetBSD/ alpha 1.3I — SHIROYAMA Takayuki <psi@...>

[#3808] 予告 : ruby 1.1d0 release is coming soon. — matz@... (Yukihiro Matsumoto)

[#3826] ruby 1.1d0 released — matz@... (Yukihiro Matsumoto)

[#3827] Method Defining Method — Shin-ichro Hara <sinara@...>

[#3836] "make test" is something wrong (ruby-1.1d0) — ttate@...

[#3846] Re: ruby 1.1d0 released — 助田 雅紀 <masaki.suketa@...>

[#3848] instruby.rb (patch for 1.1d0) — ttate@...

[#3849] Re: ruby 1.1d0 released — SHIROYAMA Takayuki <psi@...>

[#3851] tkutil patch (for 1.1d0) — ttate@...

[#3857] [patch] enum.c — shugo@... (MAEDA Shugo)

[#3859] missing/setenv.c in 1.1d0 — Inaba Hiroto <inaba@...>

[#3862] 1.1d0 new here document — Wakou Aoyama <wakou@...>

[#3864] make bug? ruby-1.1d0 — Yutaka Matsumoto <ymatsu@...>

[#3873] (?: ) does not work? — shugo@... (MAEDA Shugo)

[#3881] I want to catch all jump — shugo@... (Shugo Maeda)

[#3882] subscribe — Koji Oda <oda@...1.qnes.nec.co.jp>

[#3894] ruby 1.1d1 released — matz@... (Yukihiro Matsumoto)

[#3899] interpreter reinitialization — shugo@... (Shugo Maeda)

[#3950] Re: version number — 助田 雅紀 <masaki.suketa@...>

[#3962] ruby 1.3(!) released — matz@... (Yukihiro Matsumoto)

[#3966] [BUG] exception in safe level 4 — shugo@... (Shugo Maeda)

[#3983] compile error in gc.c — Fukuda Masaki <fukuda@...>

[#3986] Re: [ruby-list:11444] ruby 1.2 released — Hiroshi Igarashi <igarashi@...>

[#3997] [BUG] "#{}" while 1 — gotoken@... (GOTO Kentaro)

[#4002] config.guess — Koji Arai <JCA02266@...>

[#4005] [BUG] ruby 1.3(98/12/24) [i686-linux] at rb_gc_mark() — Ryo HAYASAKA <hayasaka@...>

[#4015] Integer proper methods — gotoken@... (GOTO Kentaro)

[#4030] module Precision — gotoken@... (GOTO Kentaro)

[#4032] [Req] make-symbol? — shugo@... (Shugo Maeda)

[#4035] about philos.rb — ttate@...

[#4041] static — gotoken@... (GOTO Kentaro)

[ruby-dev:3966] [BUG] exception in safe level 4

Attachments (1)

Thread

In This Thread

[#3846] Re: ruby 1.1d0 released — 助田　雅紀 <masaki.suketa@...>

[#3950] Re: version number — 助田　雅紀 <masaki.suketa@...>