From: ngotogenome@...
Date: 2015-07-31T13:29:06+00:00
Subject: [ruby-core:70204] [Ruby trunk - Bug #11336] TestProcess#test_exec_fd_3_redirect failed on Solaris 10

Issue #11336 has been updated by Naohisa Goto.


I'm sorry too late.

On Solaris 10, the patch works fine, with no error/failure during make test-all (with r51450).

> I'm not seeing it, did you notice/reproduce this failure?

No.
It seems the patch works correctly as you described.

I'm wondering whether the TODO in the following comment is still valid or not.
It seems it was first added in r32244 and was modified in r32276.

~~~
      /* close communication pipe */
      if (close_anyway) {
          /* TODO: Uninstall all signal handlers or mask all signals.
           *       This pass is cleaning phase (terminate ruby process).
           *       To avoid such race, we skip to close communication
           *       pipe.  OS will close it at process termination.
           *       It may not good practice, but pragmatic.
           *       We remain it is TODO.
           */
          /* close_communication_pipe(); */
      }
~~~


----------------------------------------
Bug #11336: TestProcess#test_exec_fd_3_redirect failed on Solaris 10
https://bugs.ruby-lang.org/issues/11336#change-53630

* Author: Naohisa Goto
* Status: Closed
* Priority: Normal
* Assignee: 
* ruby -v: ruby 2.3.0dev (2015-07-06) [sparc64-solaris2.10]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
On Solaris 10, TestProcess#test_exec_fd_3_redirect failed since r51146 (where the test was added).

~~~
  1) Failure:
TestProcess#test_exec_fd_3_redirect [/XXXXX-51146/test/ruby/test_process.rb:2049]:
<"."> expected but was
<nil>.
~~~





-- 
https://bugs.ruby-lang.org/