From: ngotogenome@...
Date: 2015-07-17T06:27:37+00:00
Subject: [ruby-core:70008] [Ruby trunk - Bug #11336] TestProcess#test_exec_fd_3_redirect failed on Solaris 10

Issue #11336 has been updated by Naohisa Goto.


> Sorry, but I think rb_divert_reserved_fd seems a racy fix.

Yes, it might be. Comparison and replacement of the fd is not atomic there, and calling dup2 after the rb_divert_reserved_fd is also a source of race.

Indeed, I implicitly expected that rb_divert_reserved_fd and dup2_with_divert were executed with GVL, but this might not be true in some cases.



----------------------------------------
Bug #11336: TestProcess#test_exec_fd_3_redirect failed on Solaris 10
https://bugs.ruby-lang.org/issues/11336#change-53442

* Author: Naohisa Goto
* Status: Closed
* Priority: Normal
* Assignee: 
* ruby -v: ruby 2.3.0dev (2015-07-06) [sparc64-solaris2.10]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
On Solaris 10, TestProcess#test_exec_fd_3_redirect failed since r51146 (where the test was added).

~~~
  1) Failure:
TestProcess#test_exec_fd_3_redirect [/XXXXX-51146/test/ruby/test_process.rb:2049]:
<"."> expected but was
<nil>.
~~~





-- 
https://bugs.ruby-lang.org/