From: mame@...
Date: 2015-07-18T12:01:29+00:00
Subject: [ruby-core:70028] [Ruby trunk - Bug #11363] Fix tests for	String#crypt

Issue #11363 has been updated by Yusuke Endoh.


Do the tests cause any actual issue?  Failed on OpenBSD?

Ruby's tests are not conformance test.  They should include a test of implementation-defined behavior and it is actually useful to detect an unintentional change of behavior.

-- 
Yusuke Endoh <mame@ruby-lang.org>

----------------------------------------
Bug #11363: Fix tests for String#crypt
https://bugs.ruby-lang.org/issues/11363#change-53453

* Author: Jeremy Evans
* Status: Open
* Priority: Normal
* Assignee: 
* ruby -v: ruby 2.3.0dev (2015-07-16 openbsd 51261) [x86_64-openbsd]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
The String#crypt documentation states "the format and the result
are system and implementation dependent", so the tests should not
be checking for specific results.  We should only be checking that
the method returns a string, that the results are different
if you use a different password or different salt, and the results
are the same if the using the encypted password as the salt
results in the same encrypted password.

---Files--------------------------------
0001-Fix-tests-for-String-crypt.patch (2.02 KB)


-- 
https://bugs.ruby-lang.org/