[ruby-core:48282] [Backport93 - Backport #7174][Assigned] Advocating for backporting 36811

Issue #7174 has been updated by h.shirosaki (Hiroshi Shirosaki).

Status changed from Closed to Assigned
Assignee changed from h.shirosaki (Hiroshi Shirosaki) to usa (Usaku NAKAMURA)

Thank you very much for backport!

But I noticed the following failure occurs.

http://u64.rubyci.org/~chkbuild/ruby-1.9.3/log/20121025T112858Z.log.html.gz

 28) Error:
test_expand_path_encoding(TestFileExhaustive):
Encoding::InvalidByteSequenceError: "\xA4" on US-ASCII
    /home/chkbuild/build/ruby-1.9.3/20121025T112858Z/ruby/test/ruby/test_file_exhaustive.rb:433:in `encode'
    /home/chkbuild/build/ruby-1.9.3/20121025T112858Z/ruby/test/ruby/test_file_exhaustive.rb:433:in `test_expand_path_encoding'


Since ruby_1_9_3 doesn't have encoding support of File.expand_path, I think skippping the test might be better.
Encoding fix seems introduced at #5919 (r34372), but r34372 was not merged according to the list.
http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-dev/45903

In my proposed backport patch skipping the test if non-windows platform.

https://github.com/thecodeshop/ruby/blob/win-file-trunk/ruby_1_9_3/test/ruby/test_file_exhaustive.rb#L439
----------------------------------------
Backport #7174: Advocating for backporting 36811
https://bugs.ruby-lang.org/issues/7174#change-31573

Author: jonforums (Jon Forums)
Status: Assigned
Priority: Normal
Assignee: usa (Usaku NAKAMURA)
Category: 
Target version: 


Please consider backporting 36811 and refinements for the following reasons:

1) While it's debatable whether this patch fixes a Windows platform bug in the 1.9.x
series or whether it's a performance refactoring, it is a fact that this patch
fixes long-standing 1.9.x usability problems important to many Ruby on Windows users.

  https://gist.github.com/3242245

2) For many months Hiroshi has maintained a 1.9.3 backport of this functionality,
with the latest version available at https://github.com/thecodeshop/ruby/tree/win-file-trunk/ruby_1_9_3
This functionality has been part of multiple tcs-ruby experimental releases over the
last 6-9 months.

3) While the functionality has been tested on 1.9.3 via tcs-ruby by many interested
devs over many months, tcs-ruby is not (and will never be) an alternative MRI distribution.
tcs-ruby's sole purpose is to be collaboration repo and proving ground for those
interested in contributing Windows and cross-platform improvements to MRI. tcs-ruby's
goal is to refine the improvements and make them available for easy inclusion into MRI.

4) As a consequence of (3), Hiroshi's 1.9.3 backports have not had as much
widespread testing as they would have if they were included in an official
RubyInstaller release. This was a purposeful decision on our part. RubyInstaller
releases are meant to track official ruby-core releases. They are meant to be stable,
not experimental releases.

As this fix is now on trunk, and will be available in the 2.0.0 release targeted
for February, I strongly believe it's time to make the functionality available in the
next 1.9.3 patch release (and RubyInstaller release) in order to get more widespread usage.

By backporting this functionality to the next 1.9.3 patch release and getting more usage
(and potentially, further refinements) we minimize risks and help enhance the smooth adoption of 2.0.0.


-- 
http://bugs.ruby-lang.org/