From: "elninorian (menuju sukses sukses)" Date: 2012-10-19T15:01:24+09:00 Subject: [ruby-core:48101] [ruby-trunk - Feature #6611] Comments requested on implementation of set_parse_func Issue #6611 has been updated by elninorian (menuju sukses sukses). http://www.howtogetaflatstomachforgirls.com/ http://www.howtogetaflatstomachforgirls.com/lose-weight/lose-weight-teenage-girls/ http://www.howtogetaflatstomachforgirls.com/uncategorized/reviews-flat-belly-diet-book-work/ http://www.howtogetaflatstomachforgirls.com/diet/diet-rich-cellulose/ http://www.howtogetaflatstomachforgirls.com/belly-fat/flat-belly-menopause/ http://www.howtogetaflatstomachforgirls.com/flat-belly/flat-belly-menu-plan-vegetarians/ http://www.howtogetaflatstomachforgirls.com/flat-stomach-for-girls/how-to-get-a-flat-stomach-for-girls-in-2-weeks/ http://www.howtogetaflatstomachforgirls.com/have-a-flat-stomach-for-girls/how-to-have-a-flat-stomach-for-girls-a/ http://www.howtogetaflatstomachforgirls.com/weight-loss-secrets/the-secret-to-losing-weight/ http://www.howtogetaflatstomachforgirls.com/exercise-to-slim-legs/exercise-to-slim-legs/ http://www.howtogetaflatstomachforgirls.com/weight-loss-secrets/lose-6-pounds-in-a-week/ http://www.howtogetaflatstomachforgirls.com/diet/ketogenic-diet-risks/ http://www.howtogetaflatstomachforgirls.com/lose-pounds/lose-6-pounds-in-two-weeks/ http://www.howtogetaflatstomachforgirls.com/belly-fat/belly-fat-under-belly-button/ http://www.howtogetaflatstomachforgirls.com/flat-stomach-for-girls/how-to-get-a-flat-stomach-for-girls-fast/ http://www.howtogetaflatstomachforgirls.com/a-flat-stomach/flat-stomach-in-a-month/ http://www.howtogetaflatstomachforgirls.com/belly-fat/flatten-belly-fast/ http://www.howtogetaflatstomachforgirls.com/abs/how-to-get-abs-for-girls-women/ http://www.howtogetaflatstomachforgirls.com/flat-stomach-fast-for-girls/how-to-get-a-flat-stomach-for-girls-a/ http://www.howtogetaflatstomachforgirls.com/flat-belly/flat-belly-solution/ http://www.howtogetaflatstomachforgirls.com/exercises-work/exercises-work-flat-stomach/ http://www.howtogetaflatstomachforgirls.com/a-flat-stomach/foods-flat-stomach/ http://www.howtogetaflatstomachforgirls.com/flat-stomach-diet-does-work/flat-stomach-diet-work/ http://www.howtogetaflatstomachforgirls.com/cardio-training-tips-workout/cardio-training-tips-workout-flat-stomach/ http://www.howtogetaflatstomachforgirls.com/bonus-buy-flat-stomach/bonus-buy-flat-stomach-diet-does-work/ http://www.howtogetaflatstomachforgirls.com/flat-stomach-ebook/flat-stomach-ebook-download/ http://www.howtogetaflatstomachforgirls.com/flat-stomach-program/flat-stomach-programme-exercise-training-workout-gym-2012/ http://www.howtogetaflatstomachforgirls.com/abs/how-to-have-defined-abs/ http://www.howtogetaflatstomachforgirls.com/weight-loss-secrets/lose-weight-while-walking/ http://www.howtogetaflatstomachforgirls.com/stomach-for-girls-in-a-week/how-to-get-a-flat-stomach-for-girls-in-a-week-for-teenagers/ http://www.howtogetaflatstomachforgirls.com/secrets-to-lose-weight-fast/secrets-to-lose-weight-fast/ http://www.howtogetaflatstomachforgirls.com/exercises-for-flat-stomach/how-to-get-a-flat-stomach-for-girls-exercises/ http://www.howtogetaflatstomachforgirls.com/to-get-a-flat-stomach-at-home-for-girls/how-to-get-a-flat-stomach-at-home-for-girls-fast-for-girls-at-home/ http://www.howtogetaflatstomachforgirls.com/tips-for-slimming-stomach/tips-for-slimming-stomach-weigh-your-belly/ http://www.howtogetaflatstomachforgirls.com/flat-stomach-for-girls/flat-stomach-for-girls/ http://www.howtogetaflatstomachforgirls.com/a-flat-stomach/a-flat-stomach-the-ideal-diet-and-exercise-system-beautiful-belly/ http://www.howtogetaflatstomachforgirls.com/belly-fat/flat-belly-menu-plan/ http://www.howtogetaflatstomachforgirls.com/flat-belly/menu-plan-flat-belly-diet/ http://www.howtogetaflatstomachforgirls.com/weight-loss-secrets/lose-3-kg-in-3-days-how-to-lose-3-kg-in-3-days/ http://www.howtogetaflatstomachforgirls.com/diet/moerman-diet/ http://www.howtogetaflatstomachforgirls.com/weight-loss-secrets/lose-4-kg-how-to-lose-4-kg/ http://www.howtogetaflatstomachforgirls.com/belly-fat/how-to-lose-belly-fat-swimming/ http://www.howtogetaflatstomachforgirls.com/belly-fat/fast-flatten-belly-fast/ http://www.howtogetaflatstomachforgirls.com/how-to-lose-3-kg-in-a-month/how-to-lose-3-kg-in-a-month/ http://www.howtogetaflatstomachforgirls.com/flat-stomach-for-girls/girls-with-flat-stomach/ http://www.howtogetaflatstomachforgirls.com/flat-stomach-for-girls/how-long-does-it-take-to-get-a-flat-stomach-for-girls/ http://www.howtogetaflatstomachforgirls.com/how-do-i-lose-weight-in-a-week/how-do-i-lose-weight-in-a-week/ http://www.fatburningfoodsformen1.com/belly-fat-exercises-for-men.htm http://www.fatburningfoodsformen1.com/abs-exercises-for-men.htm http://www.fatburningfoodsformen1.com/green-tea-burn-belly-fat.htm http://www.fatburningfoodsformen1.com/belly-fat-exercises-for-men.htm http://www.fatburningfoodsformen1.com/the-man-diet-free-download.htm ---------------------------------------- Feature #6611: Comments requested on implementation of set_parse_func https://bugs.ruby-lang.org/issues/6611#change-31059 Author: cjheath (Clifford Heath) Status: Open Priority: Normal Assignee: Category: Target version: Folk, I've implemented Twister, a new mutation testing tool to replace Heckle. It relies on a new hook into the Ruby parser, in order to modify what the parser thinks it has seen. Although I have written C extensions before, there are some aspects of the Ruby core which I'm unfamiliar with and as a result don't know the right way to handle. I'd like your comments, suggestions and improvements please. https://github.com/cjheath/ruby/commit/ea99527feaf7dd06b3e8433ec640238441b188db In particular, I'd like to know the following: 1) Do you prefer that I move the literal strings (which occur once each) to #defined? https://github.com/cjheath/ruby/commit/ea99527feaf7dd06b3e8433ec640238441b188db#L1R1003 2) Will this line of code mess up the GC, and how should I fix that? https://github.com/cjheath/ruby/commit/ea99527feaf7dd06b3e8433ec640238441b188db#L1R3853 3) The set_parse_func is extern though it should be static, but I need to move the rb_define_global_function out of thread.c. Can someone please tell me where I should move it to, since there is no Init_Parser? https://github.com/cjheath/ruby/commit/ea99527feaf7dd06b3e8433ec640238441b188db#L1R9029 https://github.com/cjheath/ruby/commit/ea99527feaf7dd06b3e8433ec640238441b188db#L3R4705 4) I think I should change set_parse_func to accept a flags argument and a block, instead of assuming all flags, and taking a Proc. What are the downsides of using a block instead of a Proc (does this reduce the number of Bindings that get created)? How do I change set_parse_func to use a block? The initial implementation of Twister is an extension to RSpec which adds the option "--twist file-or-dir". It's still a bit rough - it needs to change the reporting on the twisted runs that follow the first (untwisted) run - but it does prove then concept. Clifford Heath, Data Constellation, http://dataconstellation.com Agile Information Management and Design. -- http://bugs.ruby-lang.org/