From: "drbrain (Eric Hodel)" <drbrain@...7.net>
Date: 2012-10-12T05:05:02+09:00
Subject: [ruby-core:47915] [ruby-trunk - Bug #7088] Documentation of Timeout::timeout is wrong about which thread executes the block


Issue #7088 has been updated by drbrain (Eric Hodel).


I think deleting the paragraph would be sufficient.  We don't need to reveal the implementation details of timeout.
----------------------------------------
Bug #7088: Documentation of Timeout::timeout is wrong about which thread executes the block
https://bugs.ruby-lang.org/issues/7088#change-30332

Author: rklemme (Robert Klemme)
Status: Open
Priority: Normal
Assignee: zzak (Zachary Scott)
Category: DOC
Target version: 2.0.0
ruby -v: ruby 1.9.3p194 (2012-04-20) [i686-linux]


See http://rubydoc.info/stdlib/timeout/Timeout#timeout-class_method - it reads "The block will be executed on another thread and will be given one argument: sec."  If you make the source code visible or look into the file timeout.rb in the library you'll see that the block is invoked from the current (calling) thread.  The comment reads as if the author had wanted to do an implementation like this:

def timeout_1(timeout, &code)
  raise ArgumentError, "Invalid timeout: %p" % [timeout] unless timeout > 0
  raise ArgumentError, "No code to execute" if code.nil?

  worker = Thread.new(&code)
  worker.join(timeout) and worker.value
end

Note: this avoids bug #4285 at the expense of a potentially longer running thread.  Killing the background thread would suffer the same issues.


-- 
http://bugs.ruby-lang.org/