From: Ryan Davis <ryand-ruby@...>
Date: 2011-07-16T07:23:12+09:00
Subject: [ruby-core:38091] [Ruby 1.9 - Feature #2643][Open] test/unit redefinition check of test_* method


Issue #2643 has been updated by Ryan Davis.

Status changed from Assigned to Open
Assignee deleted (Ryan Davis)

I agree with Benoit. -w is there for a reason. If you're willing to ignore warnings coming from ruby, why would adding another line that says essentially the same thing be any better?

Regardless, I don't maintain test/unit, but I vote that this ticket be rejected.
----------------------------------------
Feature #2643: test/unit redefinition check of test_* method
http://redmine.ruby-lang.org/issues/2643

Author: Yusuke Endoh
Status: Open
Priority: Normal
Assignee: 
Category: lib
Target version: 1.9.x


=begin
 Hi, Ryan Davis --
 
 When writing test cases with test/unit, we often by mistake define a
 test function whose name is already used:
 
 
   class TestFoo < Test::Unit::TestCase
     def test_some_test  # not executed
       ...
     end
 
     ...
 
     def test_some_test  # redefined
       ...
     end
   end
 
 
 This leads to a loss of a valuable chance of test.  It is good for
 test/unit to detect and warn such a redefinition.
 
 A patch is attached.  Could you merge the patch into test/unit?
 I'm less than picky about the implementation detail and error
 message.
 
 
 
 By the attached patch, I actually found eight redefinitions in
 tests of ruby core :-)
 
 - TestUTF16#test_casecmp
   - defined by akr, redefined by akr
 
 - TestHash#test_key?
   - defined by ko1, redefined by ko1
 
 - TestHash#test_value?
   - defined by ko1, redefined by ko1
 
 - TestProc#test_proc_args_opt_and_block
   - defined by yugui, redefined by yugui
 
 - TestEncodingConverter#test_invalid_replace
   - defined by akr, redefined by akr
 
 - TestZlibGzipReader#test_gets
   - defined first by mame, redefined by mame
 
 - TestBigDecimal#test_coerce
   - defined first by mame, redefined by nobu
 
 - TestStringScanner#test_inspect
   - defined first by aamine, redefined by mame
 
 -- 
 Yusuke ENDOH <mame@tsg.ne.jp>
=end



-- 
http://redmine.ruby-lang.org