From: "NARUSE, Yui" <naruse@...>
Date: 2011-07-23T22:51:01+09:00
Subject: [ruby-core:38420] Re: Proposal to merge net2-http for Ruby 1.9.4

Hi,

(2011/07/23 0:56), Tanaka Akira wrote:
> 2011/7/20 Yehuda Katz <wycats@gmail.com>:
>> I'm not sure how to do this work with a series of smaller patches. I
>> considered it, but it was very difficult. There is no current maintainer of
>> Net::HTTP - I would be willing to maintain it if my patch was accepted.
>> Perhaps this makes a large change more acceptable?
> 
> For example, "{ }" to "do end", "def HTTP.foo" to "def self.foo",
> document refinement for current methods can be separated.
> 
> Also, file separation makes difficult to review because
> it makes "diff" doesn't work.
> So file sparation should also be a separated patch.
> 
> Your work, https://github.com/wycats/net-http, contains such modifications.

If it is hard to split into smaller patches, it is hard to review.
I can't understand detailed change of your net2-http
because of such mixed differences.

Anyway concept of changes seems acceptable.
So please suggest with a patch to Ruby's repo.

> Although net/http has no maintainer, it is not ignored.
> I think nurse watch it at least.

Yeah.

-- 
NARUSE, Yui  <naruse@airemix.jp>