From: Aaron Patterson <tenderlove@...>
Date: 2012-02-16T03:04:33+09:00
Subject: [ruby-core:42662] Re: [ruby-trunk - Feature #4970] FileUtils refactored


--XsQoSWH+UP9D9v3l
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 16, 2012 at 02:26:10AM +0900, Thomas Sawyer wrote:
>=20
> Issue #4970 has been updated by Thomas Sawyer.
>=20
>=20
> Aaron Patterson looked at it, his only remarks were that I forgot to remo=
ve a spurious comment and that I changed the indention on `private`. Since,=
 he said nothing about the implementation itself, I am assuming it looked o=
kay to him.

Ya, I think it's basically fine.  I have a few more questions that I'll
add to the diff.  Sorry it's taking me so long to respond on this. :(

> I would remove the unnecessary comment myself, but I seem to have deleted=
 the repo I was working on, and I am not sure there is a way to get it back=
 such that I can update the same pull request. It would just be easier to m=
erge then remove the comment, and if deemed necessary, rebase to a single c=
ommit.

I don't think it matters too much.  Once we have the final patch
assembled, I can just apply to trunk without the pull request.

--=20
Aaron Patterson
http://tenderlovemaking.com/

--XsQoSWH+UP9D9v3l
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (Darwin)

iQEcBAEBAgAGBQJPO/OrAAoJEJUxcLy0/6/GHvcH/3FjSBV+MxS1W6NOW/kgnkWY
SzOTLaKri31YOIiu/2hjWs40mEqWYeCOY+SdFtL6cCBDq1eGPbfgJ/ImaF0WkfS4
E1jrbTj3YtkRlCKTHGp1w/5LeSMeMqs7QxOsFi1qbtPzsbfWTYBlE3FfGX+sIc+8
ua3zD8AdtViGlUYuGazGzZOseijm6XcSE7kW7vWxp/sbuGXjoSAhqzW2HLqqMS3W
Q5V8Giyu8Lj5kmzMHHa8jOuT7y6C2x0xl4zg15gKpPAdOB2PYCFQbW80d+mwjyIr
YztHAIXsx1PlhUkwoC6iNBhF2c34YQqYBGYmYJqEFyrhIw9NblhwJ0apSBUyeCI=
=is0+
-----END PGP SIGNATURE-----

--XsQoSWH+UP9D9v3l--