[#22637] [Bug #1240] parser bug in 1.8.7 and 1.9.1p0 — Thomer Gil <redmine@...>
Bug #1240: parser bug in 1.8.7 and 1.9.1p0
12 messages
2009/03/03
[#29304] [Bug #1240] parser bug in 1.8.7 and 1.9.1p0
— Yusuke Endoh <redmine@...>
2010/04/07
Issue #1240 has been updated by Yusuke Endoh.
[#22640] [Bug #1241] Segfault with Nokogiri 1.2.1 on Ruby 1.9.1p0 — Raven Ex <redmine@...>
Bug #1241: Segfault with Nokogiri 1.2.1 on Ruby 1.9.1p0
3 messages
2009/03/03
[#22646] [Bug #1243] 1 is prime — Yuki Sonoda <redmine@...>
Bug #1243: 1 is prime
10 messages
2009/03/03
[#22651] [Bug #1243] 1 is prime
— Dave B <redmine@...>
2009/03/03
Issue #1243 has been updated by Dave B.
[#22684] [Bug #1247] YAML::load converts some dates into strings — Matthew Wilson <redmine@...>
Bug #1247: YAML::load converts some dates into strings
10 messages
2009/03/05
[#29323] [Bug #1247] YAML::load converts some dates into strings
— Yusuke Endoh <redmine@...>
2010/04/08
Issue #1247 has been updated by Yusuke Endoh.
[#29337] Re: [Bug #1247] YAML::load converts some dates into strings
— Aaron Patterson <aaron@...>
2010/04/08
On Thu, Apr 08, 2010 at 10:22:57PM +0900, Yusuke Endoh wrote:
[#29349] Re: [Bug #1247] YAML::load converts some dates into strings
— Caleb Clausen <vikkous@...>
2010/04/08
On 4/8/10, Aaron Patterson <aaron@tenderlovemaking.com> wrote:
[#29352] Re: [Bug #1247] YAML::load converts some dates into strings
— Yusuke ENDOH <mame@...>
2010/04/08
Hi,
[#22685] 1.9 conditional wait has no timeout support — Nasir Khan <rubylearner@...>
In ruby 1.8 we could use -
6 messages
2009/03/05
[#22687] [Bug #1248] e.exception(e) returns self — Tomas Matousek <redmine@...>
Bug #1248: e.exception(e) returns self
8 messages
2009/03/05
[#22696] Re: [Bug #1248] e.exception(e) returns self
— Yukihiro Matsumoto <matz@...>
2009/03/06
Hi,
[#22698] Re: [Bug #1248] e.exception(e) returns self
— Tomas Matousek <Tomas.Matousek@...>
2009/03/06
Well the reason is that arg is supposed to be a message, right? A message can be an arbitrary object. So if I pass e as a message, why it doesn't become a value of the message property?
[#22699] Re: [Bug #1248] e.exception(e) returns self
— Yukihiro Matsumoto <matz@...>
2009/03/06
Hi,
[#22715] [Bug #1251] gsub problem — Alexander Pettelkau <redmine@...>
Bug #1251: gsub problem
9 messages
2009/03/07
[#22725] [Bug #1253] Fix MSVC Build Issues — Charlie Savage <redmine@...>
Bug #1253: Fix MSVC Build Issues
13 messages
2009/03/07
[#22727] Moving ruby 1.9.1 forward on windows — Charlie Savage <cfis@...>
Hi everyone,
14 messages
2009/03/08
[#22730] Re: Moving ruby 1.9.1 forward on windows
— Austin Ziegler <halostatue@...>
2009/03/08
On Sat, Mar 7, 2009 at 7:01 PM, Charlie Savage <cfis@savagexi.com> wrote:
[#22754] Re: Moving ruby 1.9.1 forward on windows
— Charlie Savage <cfis@...>
2009/03/08
> This works until you start linking third-party upstream source that
[#22757] Re: Moving ruby 1.9.1 forward on windows
— Austin Ziegler <halostatue@...>
2009/03/08
On Sun, Mar 8, 2009 at 3:45 PM, Charlie Savage <cfis@savagexi.com> wrote:
[#22759] Re: Moving ruby 1.9.1 forward on windows
— Charlie Savage <cfis@...>
2009/03/08
Hi Austin,
[#22761] Re: Moving ruby 1.9.1 forward on windows
— Austin Ziegler <halostatue@...>
2009/03/08
On Sun, Mar 8, 2009 at 4:26 PM, Charlie Savage <cfis@savagexi.com> wrote:
[#22731] [Bug #1255] += for large strings egrigiously slow — James Lee <redmine@...>
Bug #1255: += for large strings egrigiously slow
11 messages
2009/03/08
[#22736] Ruby 1.9.1 and tail recursion optimization — =?ISO-8859-15?Q?Wolfgang_N=E1dasi-Donner?= <ed.odanow@...>
Moin, moin!
13 messages
2009/03/08
[#22739] Re: Ruby 1.9.1 and tail recursion optimization
— =?ISO-8859-15?Q?Wolfgang_N=E1dasi-Donner?= <ed.odanow@...>
2009/03/08
Wolfgang N疆asi-Donner schrieb:
[#22740] Re: Ruby 1.9.1 and tail recursion optimization
— Nobuyoshi Nakada <nobu@...>
2009/03/08
Hi,
[#22741] Re: Ruby 1.9.1 and tail recursion optimization
— James Coglan <jcoglan@...>
2009/03/08
>
[#22742] Re: Ruby 1.9.1 and tail recursion optimization
— Nikolai Weibull <now@...>
2009/03/08
On Sun, Mar 8, 2009 at 16:57, James Coglan <jcoglan@googlemail.com> wrote:
[#22743] Re: Ruby 1.9.1 and tail recursion optimization
— James Coglan <jcoglan@...>
2009/03/08
2009/3/8 Nikolai Weibull <now@bitwi.se>
[#22744] Re: Ruby 1.9.1 and tail recursion optimization
— daz <dooby@...10.karoo.co.uk>
2009/03/08
James Coglan wrote:
[#22746] Re: Ruby 1.9.1 and tail recursion optimization
— Wolfgang N疆asi-Donner <ed.odanow@...>
2009/03/08
daz schrieb:
[#22753] Re: Ruby 1.9.1 and tail recursion optimization
— Charles Oliver Nutter <charles.nutter@...>
2009/03/08
Wolfgang N叩dasi-Donner wrote:
[#22755] Re: Ruby 1.9.1 and tail recursion optimization
— Wolfgang Nádasi-Donner <ed.odanow@...>
2009/03/08
Charles Oliver Nutter schrieb:
[#22748] [Feature #1256] Add constant TAILRECURSION to let a program recognize if tail recursion optimization is implemented — Wolfgang Nádasi-Donner <redmine@...>
Feature #1256: Add constant TAILRECURSION to let a program recognize if tail recursion optimization is implemented
7 messages
2009/03/08
[#22766] Re: [Feature #1256] Add constant TAILRECURSION to let a program recognize if tail recursion optimization is implemented
— Nobuyoshi Nakada <nobu@...>
2009/03/09
Hi,
[#22803] Relegate 1.8.6 to Engine Yard, part II — Urabe Shyouhei <shyouhei@...>
Hello and sorry for my being slow for this issue. It's OK now for me to pass
21 messages
2009/03/10
[#22816] Re: Relegate 1.8.6 to Engine Yard, part II
— Ryan Davis <ryand-ruby@...>
2009/03/10
[#22833] Re: Relegate 1.8.6 to Engine Yard, part II
— Urabe Shyouhei <shyouhei@...>
2009/03/11
Ryan Davis wrote:
[#22845] Re: Relegate 1.8.6 to Engine Yard, part II
— Urabe Shyouhei <shyouhei@...>
2009/03/11
Urabe Shyouhei wrote:
[#22907] Re: Relegate 1.8.6 to Engine Yard, part II
— Nobuyoshi Nakada <nobu@...>
2009/03/16
Hi,
[#22910] Re: Relegate 1.8.6 to Engine Yard, part II
— Urabe Shyouhei <shyouhei@...>
2009/03/16
Nobuyoshi Nakada wrote:
[#23021] Re: Relegate 1.8.6 to Engine Yard, part II
— Urabe Shyouhei <shyouhei@...>
2009/03/26
Urabe Shyouhei wrote:
[#22812] [Bug #1261] cross-compiling Ruby extensions using mkmf doesn't fully respect DESTDIR — Daniel Golle <redmine@...>
Bug #1261: cross-compiling Ruby extensions using mkmf doesn't fully respect DESTDIR
8 messages
2009/03/10
[#22859] [Bug #1277] Incorrect passing of file handle between runtime libraries in OpenSSL extension — Charlie Savage <redmine@...>
Bug #1277: Incorrect passing of file handle between runtime libraries in OpenSSL extension
6 messages
2009/03/12
[#22892] Ruby Time — valodzka <valodzka@...>
Got tired of current ruby Time limitation, I have written this -
24 messages
2009/03/14
[#22949] Re: Ruby Time
— Tanaka Akira <akr@...>
2009/03/19
In article <9e19ed87-9d12-4f98-af3c-bd49a71b0bd4@p11g2000yqe.googlegroups.com>,
[#22974] Re: Ruby Time
— valodzka <valodzka@...>
2009/03/20
[#22977] Re: Ruby Time
— Urabe Shyouhei <shyouhei@...>
2009/03/20
valodzka wrote:
[#22981] Re: Ruby Time
— valodzka <valodzka@...>
2009/03/21
> I bet you'll get tired of updating that database. There's a major difference
[#22987] Re: Ruby Time
— Urabe Shyouhei <shyouhei@...>
2009/03/22
valodzka wrote:
[#22985] Re: Ruby Time
— Tanaka Akira <akr@...>
2009/03/21
In article <b5d0a489-4613-4b63-9664-8627358b2dd9@g19g2000yql.googlegroups.com>,
[#22992] Re: Ruby Time
— valodzka <valodzka@...>
2009/03/22
> I found a discussion in PHP.
[#23025] Re: Ruby Time
— Tanaka Akira <akr@...>
2009/03/26
In article <deab6882-12ac-4aa1-a901-681795ed863b@z9g2000yqi.googlegroups.com>,
[#22893] [Feature #1291] O_CLOEXEC flag missing for Kernel::open — David Martin <redmine@...>
Feature #1291: O_CLOEXEC flag missing for Kernel::open
10 messages
2009/03/15
[#29039] [Feature #1291] O_CLOEXEC flag missing for Kernel::open
— Motohiro KOSAKI <redmine@...>
2010/03/26
Issue #1291 has been updated by Motohiro KOSAKI.
[#22894] [Bug #1292] 1.8 compile time error with mingw gcc 4.3 — Roger Pack <redmine@...>
Bug #1292: 1.8 compile time error with mingw gcc 4.3
7 messages
2009/03/15
[#22895] Re: [Bug #1292] 1.8 compile time error with mingw gcc 4.3
— Nobuyoshi Nakada <nobu@...>
2009/03/15
Hi,
[#22916] [Bug #1296] [trunk/22981] 64-bit issues on trunk in ext/zlib — Ollivier Robert <redmine@...>
Bug #1296: [trunk/22981] 64-bit issues on trunk in ext/zlib
5 messages
2009/03/16
[#22927] [Bug #1301] Poor RegExp Matching Performance — Andreas Grau <redmine@...>
Bug #1301: Poor RegExp Matching Performance
7 messages
2009/03/18
[#22935] 1.8.6 rdoc breaks when rdoc'ing 1.9 — James Britt <james.britt@...>
I'm running ruby 1.8.6 (2009-03-10 patchlevel 362) [i686-linux] and
5 messages
2009/03/18
[#22937] Ruby not to be a part of Google's 2009 Summer of Code? — Rocky Bernstein <rocky.bernstein@...>
The list of participating organizations for Google's 2009 Summer of Code has
5 messages
2009/03/19
[#22978] Ruby 1.9 bloc parameters — Vincent Isambart <vincent.isambart@...>
Hi,
1 message
2009/03/20
[#22979] Ruby 1.9 bloc parameters — Vincent Isambart <vincent.isambart@...>
Hi,
1 message
2009/03/20
[#22990] [Bug #1309] dl tests — Charlie Savage <redmine@...>
Bug #1309: dl tests
5 messages
2009/03/22
[#23026] [Bug #1317] Creating a range with strings — Ian Bailey <redmine@...>
Bug #1317: Creating a range with strings
5 messages
2009/03/26
[#23050] [Bug #1322] define_method scope bug — "coderrr ." <redmine@...>
Bug #1322: define_method scope bug
5 messages
2009/03/29
[#23051] [Bug #1323] Sockets broken on windows — Charlie Savage <redmine@...>
Bug #1323: Sockets broken on windows
6 messages
2009/03/29
[#23053] [Bug #1325] fiber tests kill windows — Charlie Savage <redmine@...>
Bug #1325: fiber tests kill windows
6 messages
2009/03/29
[#23054] [Bug #1326] Failing unit tests on windows — Charlie Savage <redmine@...>
Bug #1326: Failing unit tests on windows
4 messages
2009/03/29
[#23060] [Bug #1327] CSV unit test failures on windows — Charlie Savage <redmine@...>
Bug #1327: CSV unit test failures on windows
4 messages
2009/03/29
[#23063] [Bug #1332] Reading file on Windows is 500x slower then with previous Ruby version — Damjan Rems <redmine@...>
Bug #1332: Reading file on Windows is 500x slower then with previous Ruby version
11 messages
2009/03/30
[#26505] [Bug #1332] Reading file on Windows is 500x slower then with previous Ruby version
— Roger Pack <redmine@...>
2009/11/03
Issue #1332 has been updated by Roger Pack.
[#26515] Re: [Bug #1332] Reading file on Windows is 500x slower then with previous Ruby version
— "U.Nakamura" <usa@...>
2009/11/04
Hello,
[#23075] [Bug #1336] Change in string representation of Floats — Brian Ford <redmine@...>
Bug #1336: Change in string representation of Floats
37 messages
2009/03/31
[#23116] [Bug #1336] Change in string representation of Floats
— Roger Pack <redmine@...>
2009/04/04
Issue #1336 has been updated by Roger Pack.
[#23118] Re: [Bug #1336] Change in string representation of Floats
— brian ford <brixen@...>
2009/04/04
On Fri, Apr 3, 2009 at 11:49 PM, Roger Pack <redmine@ruby-lang.org> wrote:
[#23179] [Bug #1336] Change in string representation of Floats
— Roger Pack <redmine@...>
2009/04/11
Issue #1336 has been updated by Roger Pack.
[#23181] Re: [Bug #1336] Change in string representation of Floats
— Brent Roman <brent@...>
2009/04/11
[#23186] Re: [Bug #1336] Change in string representation of Floats
— Yukihiro Matsumoto <matz@...>
2009/04/12
Hi,
[#23187] Re: [Bug #1336] Change in string representation of Floats
— Brent Roman <brent@...>
2009/04/13
[#23188] Re: [Bug #1336] Change in string representation of Floats
— Yukihiro Matsumoto <matz@...>
2009/04/13
Hi,
[#23189] Re: [Bug #1336] Change in string representation of Floats
— Brent Roman <brent@...>
2009/04/13
[#23199] Re: [Bug #1336] Change in string representation of Floats
— Yukihiro Matsumoto <matz@...>
2009/04/14
Hi,
[#23201] Re: [Bug #1336] Change in string representation of Floats
— Gary Wright <gwtmp01@...>
2009/04/14
[#23202] Re: [Bug #1336] Change in string representation of Floats
— Urabe Shyouhei <shyouhei@...>
2009/04/14
Gary Wright wrote:
[#23206] Re: [Bug #1336] Change in string representation of Floats
— Gary Wright <gwtmp01@...>
2009/04/14
[#23082] [Bug #1341] pthread_cond_timedwait failing in 1.9.1-p0 thread tests — Graham Agnew <redmine@...>
Bug #1341: pthread_cond_timedwait failing in 1.9.1-p0 thread tests
6 messages
2009/03/31
[ruby-core:22789] 1152: profiler.rb is not thread-safe
From:
James Abley <james.abley@...>
Date:
2009-03-09 22:25:48 UTC
List:
ruby-core #22789
Hi, Sample patch attached for discussion. There are style and best practice issues with this patch due to my lack of ruby experience. Please forgive and be so kind as to suggest improvements. It is intended to highlight some of the areas that must be considered when making the change to provide thread-safe profiling. The patch alters the code to make the capture of the data thread-safe AFAICT. There may be some issues with the data fields / calculations. I wasn't completely clear what each field in the array was supposed to be storing. The main issue unresolved by this patch is how best to present the information. I've opted for showing information per-thread and a summary as well. * Should there be a version number outputted, in case downstream tools are doing something with this information? * Any comments on how the information is being presented?? * Should profiling be configurable, so that it may not show output per thread, etc. Cheers, James
Attachments (1)
1152-2009-03-09.patch
(3.58 KB, text/x-diff)
Index: lib/profiler.rb
===================================================================
--- lib/profiler.rb (revision 22866)
+++ lib/profiler.rb (working copy)
@@ -1,29 +1,34 @@
module Profiler__
# internal values
- @@start = @@stack = @@map = nil
+ @@start = nil # the start time that profiling began
+ @@stacks = nil # the map of stack arrays keyed by thread
+ @@maps = nil # the map of map of call data keyed by thread, then by class and id. Call data arrays contains the call count, total time,
PROFILE_PROC = proc{|event, file, line, id, binding, klass|
case event
when "call", "c-call"
now = Process.times[0]
- @@stack.push [now, 0.0]
+ stack = (@@stacks[Thread.current] ||= [])
+ stack.push [now, 0.0]
when "return", "c-return"
now = Process.times[0]
key = [klass, id]
- if tick = @@stack.pop
- data = (@@map[key] ||= [0, 0.0, 0.0, key])
+ stack = @@stacks[Thread.current]
+ if tick = stack.pop
+ threadMap = (@@maps[Thread.current] ||= {})
+ data = (threadMap[key] ||= [0, 0.0, 0.0, key])
data[0] += 1
cost = now - tick[0]
data[1] += cost
data[2] += cost - tick[1]
- @@stack[-1][1] += cost if @@stack[-1]
+ stack[-1][1] += cost if stack[-1]
end
end
}
module_function
def start_profile
@@start = Process.times[0]
- @@stack = []
- @@map = {}
+ @@stacks = {}
+ @@maps = {}
set_trace_func PROFILE_PROC
end
def stop_profile
@@ -33,27 +38,62 @@
stop_profile
total = Process.times[0] - @@start
if total == 0 then total = 0.01 end
- data = @@map.values
+ totals = {}
+ @@maps.each { |thread, threadMap|
+ threadMap.each {|key, data|
+ total_data = (totals[key] ||= [0, 0.0, 0.0, key])
+ total_data[0] += data[0]
+ total_data[1] += data[1] #TODO summing this field doesn't make much sense? Needs discussion on ruby-core
+ total_data[2] += data[2]
+ }
+ # Print the thread output
+ print_thread(f, thread, threadMap.values, total) if @@maps.length > 1
+ }
+
+ data = totals.values
data = data.sort_by{|x| -x[2]}
- sum = 0
+
+ f.printf "Summary\n" if @@maps.length > 1
+ print_header(f)
+ print_call_sites(f, data, total)
+ print_footer(f, total)
+ end
+ def get_name(klass, id)
+ name = klass.to_s || ""
+ if klass.kind_of? Class
+ name += "#"
+ else
+ name += "."
+ end
+ name + id.id2name
+ end
+ def print_thread(f, thread, data, total)
+ data = data.sort_by{|x| -x[2]}
+ f.printf " %s\n", thread
+ print_header(f)
+ print_call_sites(f, data, total)
+ print_footer(f, total)
+ f.printf "\n"
+ end
+ def print_header(f)
f.printf " %% cumulative self self total\n"
f.printf " time seconds seconds calls ms/call ms/call name\n"
+ end
+ def print_call_sites(f, data, total)
+ sum = 0
for d in data
sum += d[2]
f.printf "%6.2f %8.2f %8.2f %8d ", d[2]/total*100, sum, d[2], d[0]
f.printf "%8.2f %8.2f %s\n", d[2]*1000/d[0], d[1]*1000/d[0], get_name(*d[3])
end
+ end
+ def print_footer(f, total)
f.printf "%6.2f %8.2f %8.2f %8d ", 0.0, total, 0.0, 1 # ???
f.printf "%8.2f %8.2f %s\n", 0.0, total*1000, "#toplevel" # ???
end
- def get_name(klass, id)
- name = klass.to_s || ""
- if klass.kind_of? Class
- name += "#"
- else
- name += "."
- end
- name + id.id2name
- end
private :get_name
+ private :print_thread
+ private :print_header
+ private :print_call_sites
+ private :print_footer
end