From: "fxn (Xavier Noria)" Date: 2022-01-24T00:32:27+00:00 Subject: [ruby-core:107246] [Ruby master Feature#18273] Class#subclasses Issue #18273 has been updated by fxn (Xavier Noria). Said in a different way: ```ruby C = Class.new -> { Class.new(C); 1 }.call pp C.subclasses pp C.subclasses ``` If GC kicks in between lines 3 and 4, you may get different results. In my opinion, this non-determinism is not good for an API like this one. ---------------------------------------- Feature #18273: Class#subclasses https://bugs.ruby-lang.org/issues/18273#change-96107 * Author: byroot (Jean Boussier) * Status: Closed * Priority: Normal ---------------------------------------- Ref: https://github.com/rails/rails/pull/43481 Something we forgot to mention in [Feature #14394], is either a parameter or another method to only get direct descendants. Active Support has been offering `Class.subclasses` as: ```ruby def subclasses descendants.select { |descendant| descendant.superclass == self } end ``` It seems a bit silly to grab all descendants and then restrict the list when `Class#descendants` had to do some recursion to get them all in the first place. ### Proposal We could either implement `Class#subclasses` directly, or accept a parameter in `Class#descendants`, e.g. `descendants(immediate = false)`. cc @eregon -- https://bugs.ruby-lang.org/ Unsubscribe: