From: "jhawthorn (John Hawthorn)" <noreply@...>
Date: 2022-02-06T18:43:15+00:00
Subject: [ruby-core:107492] [Ruby master Bug#18562] throw_data passed to rescue through require

Issue #18562 has been updated by jhawthorn (John Hawthorn).

Backport changed from 2.6: DONTNEED, 2.7: DONTNEED, 3.0: DONTNEED, 3.1: DONTNEED to 2.6: DONTNEED, 2.7: REQUIRED, 3.0: REQUIRED, 3.1: REQUIRED

byroot (Jean Boussier) wrote in #note-2:
> @jhawthorn that was a master only issue right? I could repo it with any released version.

Thanks for checking. I didn't realize this before, but it seems that this needs `--disable-gems` to reproduce, but with that I see the issue on 2.7, 3.0, and 3.1.

```
$ ruby --disable-gems -e 'puts RUBY_DESCRIPTION; class Anything < Exception; def self.===(_); true; end; end; catch(:extdep) do; begin; require "./test_throw"; rescue Anything => e; p e; end; end'
ruby 3.1.0p0 (2021-12-25 revision fb4df44d16) [x86_64-linux]
-e:1:in `p': method `inspect' called on unexpected T_IMEMO object (0x00007f3fb90e5a10 flags=0x301a) (NotImplementedError)
        from -e:1:in `rescue in block in <main>'
        from -e:1:in `block in <main>'
        from -e:1:in `catch'
        from -e:1:in `<main>'
```

I added REQUIRED for 2.7 and up, but I think it's unlikely anyone will run into this bug in real usage, so I don't feel strongly that it needs a backport if it's complicated.

----------------------------------------
Bug #18562: throw_data passed to rescue through require
https://bugs.ruby-lang.org/issues/18562#change-96396

* Author: jhawthorn (John Hawthorn)
* Status: Closed
* Priority: Normal
* Assignee: jhawthorn (John Hawthorn)
* Backport: 2.6: DONTNEED, 2.7: REQUIRED, 3.0: REQUIRED, 3.1: REQUIRED
----------------------------------------
When we throw in a require it's incorrectly considered as a raise, making the `T_IMEMO` `throw_data` object accessible via rescue (in a contrived case). In regular usage this is unlikely to cause an issue because `Module#===` immediately returns false for objects with klass == 0.

With `test_throw.rb`:
```
throw :extdep, 42
```

and 

```
class Anything < Exception
  def self.===(_); true; end
end

catch(:extdep) do
  begin
    require "./test_throw"
  rescue Anything => e
    p e
  end
end
```

We get

```
in 'p': method inspect' called on unexpected T_IMEMO object (0x00007f5e1486b130 flags=0x10000301a) (NotImplementedError)
```

I've proposed a fix via PR https://github.com/ruby/ruby/pull/5513



-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>