From: "Игорь Пятчиц via ruby-core" <ruby-core@...>
Date: 2023-10-02T20:07:20+06:00
Subject: [ruby-core:114940] Re: [Ruby master Bug#18553] Memory leak on compiling method call with kwargs

--===============8082563700824290637==
Content-Type: multipart/alternative; boundary="0000000000008a0de40606bc4b49"

--0000000000008a0de40606bc4b49
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

=F0=9F=91=8D

=D0=BF=D0=BD, 2 =D0=BE=D0=BA=D1=82. 2023=E2=80=AF=D0=B3. =D0=B2 01:57, pete=
rzhu2118 (Peter Zhu) via ruby-core <
ruby-core@ml.ruby-lang.org>:

> Issue #18553 has been updated by peterzhu2118 (Peter Zhu).
>
> Status changed from Open to Closed
>
> This was fixed in #19906, so I will close this issue.
>
> ----------------------------------------
> Bug #18553: Memory leak on compiling method call with kwargs
> https://bugs.ruby-lang.org/issues/18553#change-104808
>
> * Author: ibylich (Ilya Bylich)
> * Status: Closed
> * Priority: Normal
> * Assignee: ko1 (Koichi Sasada)
> * ruby -v: ruby 3.2.0dev
> * Backport: 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN
> ----------------------------------------
> The following code produces a memory leak:
>
> ```ruby
> p(foo: 1)
> ```
>
> It comes from the allocation in `compile.c`:
>
> ```c
> struct rb_callinfo_kwarg *kw_arg =3D
>                 rb_xmalloc_mul_add(len, sizeof(VALUE), sizeof(struct
> rb_callinfo_kwarg));
> ```
>
> Later it's packed into `struct rb_callinfo`, but `imemo_callinfo` is a
> GC-managed object that has no `free` calls in `obj_free` function in gc.c=
.
>
> [I've tried to fix it](
> https://github.com/ruby/ruby/pull/5488/files#diff-d1cee85c3b0e24a64519c11=
150abe26fd0b5d8628a23d356dd0b535ac4595d49R3397)
> by calling `free` on `callinfo->kwarg` and it fixed leak in `./miniruby -=
e
> 'p(foo: 1)'`, but it breaks `make install`. My addition causes a
> double-free error, looks like either `callinfo` or `callinfo->kwarg` is
> shared between multiple objects.
> `kwarg` field is a `const` pointer, so that's somewhat expected (I was
> under impression that `const` qualifier is redundant) :)
>
> I'm pretty sure old versions of Ruby are also affected by this memory lea=
k.
>
>
>
> --
> https://bugs.ruby-lang.org/
>  ______________________________________________
>  ruby-core mailing list -- ruby-core@ml.ruby-lang.org
>  To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
>  ruby-core info --
> https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.=
org/
>

--0000000000008a0de40606bc4b49
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">=F0=9F=91=8D<br></div><br><div class=3D"gmail_quote"><div =
dir=3D"ltr" class=3D"gmail_attr">=D0=BF=D0=BD, 2 =D0=BE=D0=BA=D1=82. 2023=
=E2=80=AF=D0=B3. =D0=B2 01:57, peterzhu2118 (Peter Zhu) via ruby-core &lt;<=
a href=3D"mailto:ruby-core@ml.ruby-lang.org">ruby-core@ml.ruby-lang.org</a>=
&gt;:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0p=
x 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Issue #185=
53 has been updated by peterzhu2118 (Peter Zhu).<br>
<br>
Status changed from Open to Closed<br>
<br>
This was fixed in #19906, so I will close this issue.<br>
<br>
----------------------------------------<br>
Bug #18553: Memory leak on compiling method call with kwargs<br>
<a href=3D"https://bugs.ruby-lang.org/issues/18553#change-104808" rel=3D"no=
referrer" target=3D"_blank">https://bugs.ruby-lang.org/issues/18553#change-=
104808</a><br>
<br>
* Author: ibylich (Ilya Bylich)<br>
* Status: Closed<br>
* Priority: Normal<br>
* Assignee: ko1 (Koichi Sasada)<br>
* ruby -v: ruby 3.2.0dev<br>
* Backport: 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN<br>
----------------------------------------<br>
The following code produces a memory leak:<br>
<br>
```ruby<br>
p(foo: 1)<br>
```<br>
<br>
It comes from the allocation in `compile.c`:<br>
<br>
```c<br>
struct rb_callinfo_kwarg *kw_arg =3D<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 rb_xmalloc_mul_add(=
len, sizeof(VALUE), sizeof(struct rb_callinfo_kwarg));<br>
```<br>
<br>
Later it&#39;s packed into `struct rb_callinfo`, but `imemo_callinfo` is a =
GC-managed object that has no `free` calls in `obj_free` function in gc.c.<=
br>
<br>
[I&#39;ve tried to fix it](<a href=3D"https://github.com/ruby/ruby/pull/548=
8/files#diff-d1cee85c3b0e24a64519c11150abe26fd0b5d8628a23d356dd0b535ac4595d=
49R3397" rel=3D"noreferrer" target=3D"_blank">https://github.com/ruby/ruby/=
pull/5488/files#diff-d1cee85c3b0e24a64519c11150abe26fd0b5d8628a23d356dd0b53=
5ac4595d49R3397</a>) by calling `free` on `callinfo-&gt;kwarg` and it fixed=
 leak in `./miniruby -e &#39;p(foo: 1)&#39;`, but it breaks `make install`.=
 My addition causes a double-free error, looks like either `callinfo` or `c=
allinfo-&gt;kwarg` is shared between multiple objects. <br>
`kwarg` field is a `const` pointer, so that&#39;s somewhat expected (I was =
under impression that `const` qualifier is redundant) :)<br>
<br>
I&#39;m pretty sure old versions of Ruby are also affected by this memory l=
eak.<br>
<br>
<br>
<br>
-- <br>
<a href=3D"https://bugs.ruby-lang.org/" rel=3D"noreferrer" target=3D"_blank=
">https://bugs.ruby-lang.org/</a><br>
=C2=A0______________________________________________<br>
=C2=A0ruby-core mailing list -- <a href=3D"mailto:ruby-core@ml.ruby-lang.or=
g" target=3D"_blank">ruby-core@ml.ruby-lang.org</a><br>
=C2=A0To unsubscribe send an email to <a href=3D"mailto:ruby-core-leave@ml.=
ruby-lang.org" target=3D"_blank">ruby-core-leave@ml.ruby-lang.org</a><br>
=C2=A0ruby-core info -- <a href=3D"https://ml.ruby-lang.org/mailman3/postor=
ius/lists/ruby-core.ml.ruby-lang.org/" rel=3D"noreferrer" target=3D"_blank"=
>https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.o=
rg/</a><br>
</blockquote></div>

--0000000000008a0de40606bc4b49--

--===============8082563700824290637==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/
--===============8082563700824290637==--