[ruby-core:115128] [Ruby master Bug#19921] TestYJIT#test_bug_19316 test failure

Issue #19921 has been updated by jaruga (Jun Aruga).


alanwu (Alan Wu) wrote in #note-18:
> Thanks! The new message confirms the issue. The test should pass now, as of commit:fab70183.

Thanks for the fix! I am glad for that.

https://github.com/ruby/ruby/commit/fab7018346488a693d34ea81f1e9d6fec476f06e
> Because the `&` call checks for interrupts, the test was accidentally
> timing dependent. Stop checking for exits.

Seeing the commit message, what the "`&` call checks" mean? What makes the failure?


I observed that the test `TestYJIT#test_bug_19316` failed for the Ruby (based on the `ef3f9f1a685effb51543d1f08831692fa68863a2` + patch files) before the fixed commit, on Fedora rawhide (Fedora 40), 39, 38 every time so far.

Below is the command log on Fedora's build environment (called mock environment) for the Ruby above.

```
$ make -C redhat-linux-build test-all TESTS="../test/ruby/test_yjit.rb -n TestYJIT#test_bug_19316 -v"
...
# Running tests:

[1/1] TestYJIT#test_bug_19316 = 1.12 s

  1) Failure:
TestYJIT#test_bug_19316 [/builddir/build/BUILD/ruby-3.3.0-ef3f9f1a68/test/ruby/test_yjit.rb:1152]:
Expected no exits, but got
{:opt_and=>1}

Finished tests in 1.123462s, 0.8901 tests/s, 4.4505 assertions/s.
1 tests, 5 assertions, 1 failures, 0 errors, 0 skips
```

I was planning to check the variations of the builds to find which factor causes the failure. But as you fixed the issue, I will pend the investigation happily for now.

* Ruby + no additional patches + the compiler flags used to build RPM in Fedora + Fedora's build environment.
* Ruby + no additional patches + the compiler flags used to build RPM in Fedora  + RubyCI Fedora 38 server.
* Ruby + no additional patches + the variations of the compiler flags + RubyCI Fedora 38 server.


----------------------------------------
Bug #19921: TestYJIT#test_bug_19316 test failure
https://bugs.ruby-lang.org/issues/19921#change-105034

* Author: vo.x (Vit Ondruch)
* Status: Closed
* Priority: Normal
* Assignee: yjit
* ruby -v: ruby 3.3.0dev (2023-10-12 master 52709a4862) [x86_64-linux]
* Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN
----------------------------------------
Testing with 52709a4862 on Fedora Rawhide, I observe following failure:

~~~
 94) Failure:
TestYJIT#test_bug_19316 [/builddir/build/BUILD/ruby-3.3.0-52709a4862/test/ruby/test_yjit.rb:1126]:
Expected no exits, but got
{:opt_and=>1}
~~~



-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- [e-mail]
 To unsubscribe send an email to [e-mail]
 ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/