[ruby-core:104453] [Ruby master Bug#18016] fiddle\types.rb typealias maybe wrong

Issue #18016 has been updated by jeremyevans0 (Jeremy Evans).

Backport changed from 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: UNKNOWN to 2.6: UNKNOWN, 2.7: REQUIRED, 3.0: REQUIRED
Status changed from Open to Closed

This was fixed upstream just after the release of 3.0: https://github.com/ruby/fiddle/commit/28ee5b16086f77e1f079853bff2ee1cb527cb69c.  These changes have already been applied to the master branch. Possibly commit:8758b07b1e4fd636dffb4b442388a3033c63d4b5 needs to be backported to 3.0 and 2.7.


----------------------------------------
Bug #18016: fiddle\types.rb typealias maybe wrong
https://bugs.ruby-lang.org/issues/18016#change-92708

* Author: fitmap (Justin Peal)
* Status: Closed
* Priority: Normal
* ruby -v: ruby 3.0.1p64 (2021-04-05 revision 0fb782ee38) [x64-mingw32]
* Backport: 2.6: UNKNOWN, 2.7: REQUIRED, 3.0: REQUIRED
----------------------------------------
in ...\lib\ruby\3.0.0\fiddle\types.rb

module Fiddle
  module Win32Types
    def included(m) # :nodoc:
      m.module_eval{
        # ...
        typealias "HANDLE", "uintptr_t"
        # ...
        typealias "HINSTANCE", "unsigned int"
        typealias "HDC", "unsigned int"
        typealias "HWND", "unsigned int"
      }
    end
    module_function :included
  end
  # ...
end

HINSTANCE, HDC, HWND are pointers to struct, so in 64-bit system, the size of them will be 64 bits, not unsigned int (32bits).

In minwindef.h :

DECLARE_HANDLE(HINSTANCE);

In windef.h :

DECLARE_HANDLE(HDC);
DECLARE_HANDLE            (HWND);

In winnt.h :

#define DECLARE_HANDLE(name) struct name##__{int unused;}; typedef struct name##__ *name

So I suggest typealias in types.rb change to:

        typealias "HINSTANCE", "void*"
        typealias "HDC", "void*"
        typealias "HWND", "void*"




-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:[e-mail]?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>