From: "nobu (Nobuyoshi Nakada)" Date: 2021-12-03T13:49:43+00:00 Subject: [ruby-core:106458] [Ruby master Feature#18033] Time.new to parse a string Issue #18033 has been updated by nobu (Nobuyoshi Nakada). Eregon (Benoit Daloze) wrote in #note-17: > Hence, why not make `Time.iso8601` fast and a core method? > Then code already using the right method would just become faster, and there is no need migrate code to use a new API. First, the primary target is the result of `Time#inspect`, and it is not fully compliant with ISO-8601. Second, ISO-8601 allows many variants, but I'm not going to implement them all. ---------------------------------------- Feature #18033: Time.new to parse a string https://bugs.ruby-lang.org/issues/18033#change-95115 * Author: nobu (Nobuyoshi Nakada) * Status: Open * Priority: Normal ---------------------------------------- Make `Time.new` parse `Time#inspect` and ISO-8601 like strings. * `Time.iso8601` and `Time.parse` need an extension library, `date`. * `Time.iso8601` can't parse `Time#inspect` string. * `Time.parse` often results in unintentional/surprising results. * `Time.new` also about 1.9 times faster than `Time.iso8601`. ``` $ ./ruby -rtime -rbenchmark -e ' n = 1000 s = Time.now.iso8601 Benchmark.bm(12) do |x| x.report("Time.iso8601") {n.times{Time.iso8601(s)}} x.report("Time.parse") {n.times{Time.parse(s)}} x.report("Time.new") {n.times{Time.new(s)}} end' user system total real Time.iso8601 0.006919 0.000185 0.007104 ( 0.007091) Time.parse 0.018338 0.000207 0.018545 ( 0.018590) Time.new 0.003671 0.000069 0.003740 ( 0.003741) ``` https://github.com/ruby/ruby/pull/4639 -- https://bugs.ruby-lang.org/ Unsubscribe: