[#100309] How to use backport custom field — Jun Aruga <jaruga@...>
Please allow my ignorance.
9 messages
2020/10/06
[#100310] Re: How to use backport custom field
— "NARUSE, Yui" <naruse@...>
2020/10/06
IkJhY2twb3J0IGN1c3RvbSBmaWVsZCIgaXMgb25seSBhdmFpbGFibGUgZm9yIHRpY2tldHMgd2hv
[#100311] Re: How to use backport custom field
— Jun Aruga <jaruga@...>
2020/10/06
On Tue, Oct 6, 2020 at 4:44 PM NARUSE, Yui <naruse@airemix.jp> wrote:
[#100314] Re: How to use backport custom field
— "NARUSE, Yui" <naruse@...>
2020/10/06
VGhhbmsgeW91IGZvciBjb25maXJtYXRpb24uCkkgY2hlY2tlZCBhZ2FpbiBhbmQgdG8gZWRpdCBi
[#100322] Re: How to use backport custom field
— Jun Aruga <jaruga@...>
2020/10/07
On Tue, Oct 6, 2020 at 7:25 PM NARUSE, Yui <naruse@airemix.jp> wrote:
[#100326] Re: How to use backport custom field
— "NARUSE, Yui" <naruse@...>
2020/10/07
SSBhZGRlZCB5b3UgdG8gIlJlcG9ydGVyIiByb2xlIGluIHRoZSBwcm9qZWN0CgoyMDIw5bm0MTDm
[#100327] Re: How to use backport custom field
— Jun Aruga <jaruga@...>
2020/10/07
On Wed, Oct 7, 2020 at 1:42 PM NARUSE, Yui <naruse@airemix.jp> wrote:
[ruby-core:100612] [Ruby master Feature#9459] Net::HTTP initializes openssl library after TCP connection is established
From:
merch-redmine@...
Date:
2020-10-27 21:55:15 UTC
List:
ruby-core #100612
Issue #9459 has been updated by jeremyevans0 (Jeremy Evans). Backport deleted (1.9.3: UNKNOWN, 2.0.0: UNKNOWN, 2.1: UNKNOWN) ruby -v deleted (ruby 1.8.7 (2012-02-08 patchlevel 358) [universal-darwin12.0]) Tracker changed from Bug to Feature This appears to still be an issue, though I think this is a feature request and not a bug. I've submitted the patch as a pull request to the net-http repository: https://github.com/ruby/net-http/pull/4 ---------------------------------------- Feature #9459: Net::HTTP initializes openssl library after TCP connection is established https://bugs.ruby-lang.org/issues/9459#change-88243 * Author: joshc (Josh C) * Status: Assigned * Priority: Normal * Assignee: naruse (Yui NARUSE) ---------------------------------------- When making an HTTPS connection, the Net::HTTP#connect method makes the following calls: 1. TCPSocket.new 2. OpenSSL:SSL::SSLContext.new 3. OpenSSL:SSL:SSLSocket.connect Here is a link to the [2.1.0](https://github.com/ruby/ruby/blob/v2_1_0/lib/net/http.rb#L877-L920) version, though the basic sequence is the same in trunk and as far back as 1.8.7, possibly earlier. The problem is that between step 1 and 3, the server must keep the TCP socket open while the SSL client calls OpenSSL:SSL::SSLContext.new. The first time this code path is taken, step 2 has the side effect of initializing the OpenSSL library. This can take a non-trivial amount of time, and is made worse when several clients start at the same time. I would suggest that the order of operations be switched to: 1. OpenSSL:SSL::SSLContext.new 2. TCPSocket.new 3. OpenSSL:SSL:SSLSocket.connect I've attached a patch that shows this. It is based off of trunk. Thank you ---Files-------------------------------- net_http_connect.patch (742 Bytes) -- https://bugs.ruby-lang.org/ Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe> <http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>