From: lukas@... Date: 2020-10-07T11:24:38+00:00 Subject: [ruby-core:100325] [Ruby master Feature#17219] Make URI#hostname 86-89% and hostname= 55-154% faster Issue #17219 has been updated by lzap (Lukas Zapletal). Description updated Subject changed from Make URI#hostname 18-20% and hostname= 31-156% faster to Make URI#hostname 86-89% and hostname= 55-154% faster So I learned that URI is a separate rubygem, therefore I filed PR against https://github.com/ruby/uri/pull/12 and this RM issue is no longer necessary I guess. Please close. ---------------------------------------- Feature #17219: Make URI#hostname 86-89% and hostname= 55-154% faster https://bugs.ruby-lang.org/issues/17219#change-87906 * Author: lzap (Lukas Zapletal) * Status: Open * Priority: Normal ---------------------------------------- Hello, URI#hostname extends URI#host with IPv6 support. In URI, IPv6 address must have square brackets (e.g. `http://[2001:db8::1]`), URI#hostname strips these characters out while URI#hostname= adds them if missing. There are three regular expressions to perform these tasks which can dramatically slow down performance. I am attaching a two-line patch and here is a benchmark: https://gist.github.com/lzap/24cbecb47daf29111350e41a24250922 Results are in the gist. A patch and a PR incoming. ---Files-------------------------------- 3635.patch (974 Bytes) -- https://bugs.ruby-lang.org/ Unsubscribe: