From: Greg.mpls@... Date: 2018-08-28T03:53:53+00:00 Subject: [ruby-core:88702] [Ruby trunk Bug#15035] Windows make install failures Issue #15035 has been updated by MSP-Greg (Greg L). @hsbt Thanks for applying the patch. I should have been clearer, as the patch fixes two issues, both involving RubyGems, but one of the patched files (tool/rbinstall.rb) is patched for the parameter passed to a RubyGems method. That fix is what removes the error at line 30801 of the Appveyor log, https://ci.appveyor.com/project/ruby/ruby/build/9490/job/awckr1if158iu9b3#L3081 In the original PR (https://github.com/ruby/ruby/pull/1942), I had some typos that I didn't see testing locally on mingw, once fixed, Travis passed. With the patches from the PR, ruby-loco passed at ruby 2.6.0dev (2018-08-28 trunk 64581) [x64-mingw32], and mswin passed on my fork at https://ci.appveyor.com/project/MSP-Greg/ruby/build/8, but I'm not sure what rev/commit that was at, as the mswin build script does not show the revision number. I think mswin may be locking on test-all from some of the other recent commits. ruby-loco just passed again at r64582. I realize the spec patch is probably better left for @Eregon to review. Thanks, Greg ---------------------------------------- Bug #15035: Windows make install failures https://bugs.ruby-lang.org/issues/15035#change-73760 * Author: MSP-Greg (Greg L) * Status: Closed * Priority: Normal * Assignee: * Target version: * ruby -v: ruby 2.6.0dev (2018-08-28 trunk 64578) [x64-mingw32] * Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN ---------------------------------------- @hsbt Windows has been failing on install, seems due to a combination of RubyGems changes. ruby-loco is passing with the patch, and the ruby/ruby mswin is completing make install (but failing on some recent spec changes). See GH PR 1942 (https://github.com/ruby/ruby/pull/1942). Patch attached. Thanks, Greg ---Files-------------------------------- make_install_rg.patch (1.81 KB) -- https://bugs.ruby-lang.org/ Unsubscribe: