[ruby-core:88346] [Ruby trunk Misc#14962] [PATCH] thread_pthread: stop trying to deal with cancellation

From: ko1@...
Date: 2018-08-08 06:35:35 UTC
List: ruby-core #88346
Issue #14962 has been updated by ko1 (Koichi Sasada).


I don't know about these deleted code. Who introduced?


----------------------------------------
Misc #14962: [PATCH] thread_pthread: stop trying to deal with cancellation
https://bugs.ruby-lang.org/issues/14962#change-73374

* Author: normalperson (Eric Wong)
* Status: Closed
* Priority: Normal
* Assignee: 
----------------------------------------
thread_pthread: stop trying to deal with cancellation

We don't use pthreads cancellation ourselves and it's painful to
use correctly.  Any cancelled threads would break
vm->living_threads, GVL, thread_sync.c, autoload, etc...

So don't bother caring; because we can't stop rogue extensions
from completely breaking the VM in other ways, either.


Am I missing something, here?  Will commit in a few days.
Deleting code feels good :>


---Files--------------------------------
0001-thread_pthread-stop-trying-to-deal-with-cancellation.patch (2.2 KB)


-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>

In This Thread

Prev Next