[ruby-core:88355] [Ruby trunk Feature#14426][Closed] [PATCH] openssl: reduce memory allocation in OpenSSL::Buffering#do_write

Issue #14426 has been updated by rhenium (Kazuki Yamaguchi).

Status changed from Assigned to Closed

The patch is now in ruby/openssl (upstream)'s master branch and Ruby trunk.

For the record, the GitHub Pull Requests are:

https://github.com/ruby/ruby/pull/1924
https://github.com/ruby/openssl/pull/212

----------------------------------------
Feature #14426: [PATCH] openssl: reduce memory allocation in OpenSSL::Buffering#do_write
https://bugs.ruby-lang.org/issues/14426#change-73382

* Author: janko (Janko Marohnić)
* Status: Closed
* Priority: Normal
* Assignee: rhenium (Kazuki Yamaguchi)
* Target version: 
----------------------------------------
When writing data to an SSLSocket, there are a lot of, in my opinion, unnecessary strings being allocated, concretely in OpenSSL::Buffering#do_write.

When the buffer would be written, it would always be copied into a new string first, regardless of whether the write was partial or not. And in case of partial writes, it's not necessary to create copies of remaining data, we could just use the `String[from, length] = ""` trick immediately which modifies the string in-place.

I also thought that splitting writes on newlines was adding unnecessary memory allocations, so I removed that.

I tested uploading a 5MB file using HTTP.rb, and memory allocation went from 7.7 MB to 0.2 MB with this change.

~~~ ruby
require "http"
require "memory_profiler"
require "stringio"

body = StringIO.new("a" * 5*1024*1024)

MemoryProfiler.report do
  HTTP.post("https://example.com", body: body)
end.pretty_print
~~~


---Files--------------------------------
openssl-memory-allocation.patch (913 Bytes)


-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:[e-mail]?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>