From: Greg.mpls@... Date: 2018-08-23T17:28:55+00:00 Subject: [ruby-core:88619] [Ruby trunk Bug#15020] [PATCH] Add 'guards' for mswin, mingw, update test_readline.rb Issue #15020 has been reported by MSP-Greg (Greg L). ---------------------------------------- Bug #15020: [PATCH] Add 'guards' for mswin, mingw, update test_readline.rb https://bugs.ruby-lang.org/issues/15020 * Author: MSP-Greg (Greg L) * Status: Open * Priority: Normal * Assignee: * Target version: * ruby -v: * Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN ---------------------------------------- When the mingw build was added, test_readline.rb failed. One test fails on mingw, several tests error due to the windows issue with "can't close a file with an existing ref on it". See [GH PR #1941](https://github.com/ruby/ruby/pull/1941). Both the PR and a ruby-loco build using the same patch passed. This adds mswin? & mingw? methods to MiniTest::Unit::Guard, fixup readline test for mingw The patch is at https://patch-diff.githubusercontent.com/raw/ruby/ruby/pull/1941.patch or see attached. Also reverts some of r64365 and all of r64369. Thanks, Greg ---Files-------------------------------- test-readline-test_readline.rb.patch (2.31 KB) -- https://bugs.ruby-lang.org/ Unsubscribe: