[ruby-core:85532] Re: [Ruby trunk Misc#14470] Use Commit together with co-authors Github feature in svn commits

[e-mail] wrote:
> nobu (Nobuyoshi Nakada) wrote:
> > The feature page says "Include your trailers at the end of
> > your commit message", does it work even if "git-svn-id:"
> > line is appended by `git svn dcommit`?
> 
> It will work, but we have to ensure there is no newline
> between the git-svn-id trailer and the Co-authored-by trailer.
> I just did a test with a test SVN repository, and it looks
> like git-svn will insert a newline even if there are trailers
> at the end of the commit message.  Perhaps we could fix
> "git-svn", but it doesn't look like we can add arbitrary git
> trailers today.

I wouldn't accept such a change to git-svn (explanation below).
Better to make trailer interpretation tolerate empty lines;
as trailers are a loose format, anyways (or filter out
git-svn-id: lines before interpreting trailers).


Since the earliest incarnations of git-svn in 2006, I've strived
to maintain deterministic behavior across git versions as long
as the same options (usually defaults) are used; so SHA-1
identifiers for commits could end up being identical (and thus
shareable) between contributors who previously had no contact.

Unsubscribe: <mailto:[e-mail]?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>