From: shevegen@... Date: 2018-02-11T00:44:26+00:00 Subject: [ruby-core:85495] [Ruby trunk Feature#14462] MJIT enabled should be displayed in the version string Issue #14462 has been updated by shevegen (Robert A. Heiler). I somewhat agree with the general notion of the suggestion. I am not entirely sure whether it should also be added to the ruby version string, but I also have no problem with it either, so I am fine either way. For benchmarks, it may be useful to automatically add the information whether mjit is enabled or not, but to also provide means to disable that extra information when a ruby user wants to do so. Your suggestion to do so not by default but via -v is also fine (in this case it would mean that, if we omit "-v" there, we'd not get the information that mjit is used, in benchmarks; correct me if I am wrong please, I just want to define some of the behaviour). Considering that mjit will be an important addition in 2018, the more information and documentation that exists with it, the better, in my opinion - perhaps even have a subsection on the official docs that refer specifically to mjit and what it is doing (does not have to be long, just a little page for people to get a headstart about mjit, when they never heard about it before; not everyone follows all changes or watches every video on ruby conferences :) ). ---------------------------------------- Feature #14462: MJIT enabled should be displayed in the version string https://bugs.ruby-lang.org/issues/14462#change-70291 * Author: chrisseaton (Chris Seaton) * Status: Open * Priority: Normal * Assignee: * Target version: ---------------------------------------- Whether or not MJIT is enabled will probably be an important part of diagnosing bugs. It's also useful for when benchmarking - we often run benchmarks with `-v`, and other implementations that have JITs give information about whether their JIT is enabled and with what basic options in this string. For example TruffleRuby (Graal being the JIT) ~~~ truffleruby 0.31, like ruby 2.3.5 [darwin-x86_64] ~~~ And JRuby ~~~ jruby 9.1.13.0 (2.3.3) 2017-09-06 8e1c115 Java HotSpot(TM) 64-Bit Server VM 25.144-b01 on 1.8.0_144-b01 +jit [darwin-x86_64] ~~~ CRuby could display the version string something like this ~~~ ruby 2.6.0dev (2018-02-07 jit-version 62270) [x86_64-darwin17] +JIT ~~~ I've attached a patch, but I wasn't sure how to get the information into the version module, and I wasn't sure if `rb_version` was part of the API so I didn't want to modify that, so it may be a bit of a messy solution I'm afraid. ---Files-------------------------------- jit-version.diff (1.43 KB) -- https://bugs.ruby-lang.org/ Unsubscribe: