From: nobu@...
Date: 2014-06-08T09:21:04+00:00
Subject: [ruby-core:62993] [ruby-trunk - Bug #9919] [Rejected] Hardcoding the value of SIZEOF_VOIDP

Issue #9919 has been updated by Nobuyoshi Nakada.

Description updated
Status changed from Open to Rejected

`sizeof` expression is not a preprocessor constant.


----------------------------------------
Bug #9919: Hardcoding the value of SIZEOF_VOIDP
https://bugs.ruby-lang.org/issues/9919#change-47082

* Author: Marty Plummer
* Status: Rejected
* Priority: Normal
* Assignee: Nobuyoshi Nakada
* Category: misc
* Target version: 
* ruby -v: 2.1.2p95
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN
----------------------------------------
Greetings,

While this may be a small issue, I think many c-language libraries would benefit from this suggestion;

While compiling ruby from source, `SIZEOF_VOIDP` is determined and hard-coded into $prefix/ruby-$version/$RUBY_PLATFORM/ruby/config.h, as `#define SIZEOF_VOIDP <determined size>;` would it not be simpler to simply `#define SIZEOF_VOIDP sizeof(void*)`, as this would be proper on any platform one would compile on automatically, and prevent redefinition warnings when using additional libraries (case in point, when compiling a sdl+ruby application their definitions differ)

Just a small idea, I'll be posting a similar bug to sdl as well, and any other libraries I can encounter this on in daily use.




-- 
https://bugs.ruby-lang.org/