[ruby-core:60988] [ruby-trunk - Bug #9356] TCPSocket.new does not seem to handle INTR

Issue #9356 has been updated by Eric Wong.


 [e-mail] wrote:
 > >  http://bogomips.org/ruby.git/patch?id=d8241102f54
 > >    git://80x24.org/ruby socket-connect-check-v4
 > 
 > The code looks fine, but please remove the following comment in wait_connectable().
 > 
 >      * So it's enough to wait only RB_WAITFD_OUT and check the pending error
 >      * by getsockopt().
 
 OK, I'll remove if we commit these versions.
 
 > Or there might be no need to wait RB_WAITFD_IN.  I'm not sure.
 
 No need on Linux, but I think it is also harmless.
 
 I'd like to hear from Charlie to see if -v4 or -v5 can fix
 his error, first.  -v5 might be more better, in fact..

----------------------------------------
Bug #9356: TCPSocket.new does not seem to handle INTR
https://bugs.ruby-lang.org/issues/9356#change-45389

* Author: Charlie Somerville
* Status: Open
* Priority: Normal
* Assignee: 
* Category: 
* Target version: 
* ruby -v: -
* Backport: 1.9.3: UNKNOWN, 2.0.0: UNKNOWN, 2.1: UNKNOWN
----------------------------------------
TCPSocket.new does not seem to handle EINTR properly.

In the attached test script, I try to open a TCP connection to my server and make an HTTP request while a background thread continually sends a signal to the process.

This causes the #write call to fail with:

x.rb:13:in `write': Socket is not connected (Errno::ENOTCONN)
	from x.rb:13:in `<main>'

This also appears to affect 2.0.0. 1.9.3 is unaffected.

---Files--------------------------------
socket-eintr.rb (207 Bytes)
wait_connectable_infinite_loop_minimal_fix.diff (478 Bytes)


-- 
http://bugs.ruby-lang.org/