[#60404] is RB_GC_GUARD needed in rb_io_syswrite? — Eric Wong <normalperson@...>
I haven't gotten it to crash as-is, but it seems like we need to
4 messages
2014/02/01
[#60682] volatile usages — Eric Wong <normalperson@...>
Hi all, I went ahead and removed some use of volatile which were once
5 messages
2014/02/13
[#60794] [RFC] rearrange+pack vtm and time_object structs — Eric Wong <normalperson@...>
Extracted from addendum on top of Feature #9362 (cache-aligned objects).
4 messages
2014/02/16
[#61139] [ruby-trunk - Feature #9577] [Open] [PATCH] benchmark/driver.rb: align columns in text output — normalperson@...
Issue #9577 has been reported by Eric Wong.
3 messages
2014/02/28
[ruby-core:60827] [ruby-trunk - Bug #9529] [Assigned] TarHeader (Gem::Package) doesn't parse size correctly for +8GB entries
From:
luislavena@...
Date:
2014-02-18 15:33:01 UTC
List:
ruby-core #60827
Issue #9529 has been updated by Luis Lavena. Status changed from Open to Assigned Assignee set to Eric Hodel ---------------------------------------- Bug #9529: TarHeader (Gem::Package) doesn't parse size correctly for +8GB entries https://bugs.ruby-lang.org/issues/9529#change-45243 * Author: Eran Hirsch * Status: Assigned * Priority: Normal * Assignee: Eric Hodel * Category: lib/rubygems * Target version: * ruby -v: ruby 1.9.3p448 (2013-06-27 revision 41675) [x86_64-darwin13.0.0] * Backport: 1.9.3: UNKNOWN, 2.0.0: UNKNOWN, 2.1: UNKNOWN ---------------------------------------- * The current TAR header parsing code assumes the size is represented as an octal string * Because this is a 12-byte, null-terminated field, effectively this can represent up to 8GB (8^11). * For bigger files the standard allows to define the field as a 12-byte INTEGER instead. * When using this form, the first bit of the field should be turned on to signal that it is used. Currently, TAR files containing files larger then 8GB in this format would fail parsing because size would be computed as 0. (Wiki with some description of the logic, couldn't find a more "formal" document: http://en.wikipedia.org/wiki/Tar_(computing)#File_header) The problem is with this code: http://yard.ruby-doc.org/stdlib-2.1.0/Gem/Package/TarHeader.html#from-class_method The line that assigns the value to size should be conditioned on the value of the first bit, and should treat the two cases differently -- http://bugs.ruby-lang.org/