[#60404] is RB_GC_GUARD needed in rb_io_syswrite? — Eric Wong <normalperson@...>
I haven't gotten it to crash as-is, but it seems like we need to
4 messages
2014/02/01
[#60682] volatile usages — Eric Wong <normalperson@...>
Hi all, I went ahead and removed some use of volatile which were once
5 messages
2014/02/13
[#60794] [RFC] rearrange+pack vtm and time_object structs — Eric Wong <normalperson@...>
Extracted from addendum on top of Feature #9362 (cache-aligned objects).
4 messages
2014/02/16
[#61139] [ruby-trunk - Feature #9577] [Open] [PATCH] benchmark/driver.rb: align columns in text output — normalperson@...
Issue #9577 has been reported by Eric Wong.
3 messages
2014/02/28
[ruby-core:60931] Re: [ruby-trunk - Feature #9508] Add method coverage and branch coverage metrics
From:
Eric Wong <normalperson@...>
Date:
2014-02-21 07:57:07 UTC
List:
ruby-core #60931
sam.rawlins@gmail.com wrote: > Good call Eric. I've carried out your suggestion [1], and attached the cumulative patch. > > [1] this commit: https://github.com/srawlins/ruby/commit/cc50eab44f5ce0a4febdc05bdd99a09708e78b7e Thanks Sam! I didn't check very closely, but in places where before where you checked for "iseq->coverage" being true, now jumps straight to "iseq->coverage->(methods|branches|lines)". Wouldn't that crash if iseq->coverage isn't set at all? Unless I'm missing another check elsewhere, perhaps checking: (iseq->coverage && iseq->coverage->FOO) is safer.