[#60404] is RB_GC_GUARD needed in rb_io_syswrite? — Eric Wong <normalperson@...>
I haven't gotten it to crash as-is, but it seems like we need to
4 messages
2014/02/01
[#60682] volatile usages — Eric Wong <normalperson@...>
Hi all, I went ahead and removed some use of volatile which were once
5 messages
2014/02/13
[#60794] [RFC] rearrange+pack vtm and time_object structs — Eric Wong <normalperson@...>
Extracted from addendum on top of Feature #9362 (cache-aligned objects).
4 messages
2014/02/16
[#61139] [ruby-trunk - Feature #9577] [Open] [PATCH] benchmark/driver.rb: align columns in text output — normalperson@...
Issue #9577 has been reported by Eric Wong.
3 messages
2014/02/28
[ruby-core:60732] [ruby-trunk - Feature #3219] assert now passes non-boolean result
From:
nobu@...
Date:
2014-02-14 10:12:07 UTC
List:
ruby-core #60732
Issue #3219 has been updated by Nobuyoshi Nakada.
Description updated
----------------------------------------
Feature #3219: assert now passes non-boolean result
https://bugs.ruby-lang.org/issues/3219#change-45154
* Author: Nobuyoshi Nakada
* Status: Assigned
* Priority: Normal
* Assignee: Shota Fukumori
* Category:
* Target version: next minor
----------------------------------------
Hi,
Test::Unit::Assertions#assert now passes non-boolean values
(neither true nor false).
It is not only an incompatibility against former TestUnit, also
makes wrong tests (e.g., [ruby-core:29861]) passing.
```
diff --git a/lib/test/unit/assertions.rb b/lib/test/unit/assertions.rb
index 821faf5..52d5201 100644
--- a/lib/test/unit/assertions.rb
+++ b/lib/test/unit/assertions.rb
@@ -10,6 +10,16 @@ module Test
obj.pretty_inspect.chomp
end
+ def assert(result, *args, &b)
+ super(result == true || result == false, "assertion result must be true or false")
+ super
+ end
+
+ def refute(result, *args, &b)
+ super(result == true || result == false, "assertion result must be true or false")
+ super
+ end
+
def assert_raise(*args, &b)
assert_raises(*args, &b)
end
```
--
Nobu Nakada
--
http://bugs.ruby-lang.org/