From: kou@...
Date: 2014-02-01T14:54:58+00:00
Subject: [ruby-core:60410] [ruby-trunk - Bug #9367] REXML::XmlDecl doesn't use user specified quotes

Issue #9367 has been updated by Kouhei Sutou.


* `include StringQuotes` after `private` is meaningless. Please put it the top of class definition.
* It seems that `strip_quotes` is needless for `adjust_prologue_quotes`. Can we just remove `.inspect` from `adjust_prologue_quotes XXX.inspect`? If we can do it, `adjust_prologue_quotes` isn't good name. `quote` or something will be good name.
* Please don't omit parenthesis for method call in `#{...}`.
* Please don't set `DocDecl` as `NotationDecl`'s parent. (It was mentioned at #9367-9.) How about calling `context` method instead of getting context from `@parent` in `adjust_prologue_quotes`? It seems that `adjust_prologue_quotes` is too depends on internal implementation.

(Sorry for my many comments...)


----------------------------------------
Bug #9367: REXML::XmlDecl doesn't use user specified quotes
https://bugs.ruby-lang.org/issues/9367#change-44879

* Author: Takashi Oguma
* Status: Assigned
* Priority: Normal
* Assignee: Kouhei Sutou
* Category: 
* Target version: 
* ruby -v: ruby 2.0.0p247 (2013-06-27 revision 41674) [x86_64-linux]
* Backport: 1.9.3: UNKNOWN, 2.0.0: UNKNOWN, 2.1: UNKNOWN
----------------------------------------
=begin
REXML uses double quotes for quoting attributes if :attribute_quote is specified as document's context like below:

 doc = REXML::Document.new
 doc.context[:attribute_quote] = :quote

This looks working well on all elements but has no effect for xml declaration (i.e. <?xml version= ... ?>) if it exists.

Even if I specify (({doc.context[:attribute_quote] = :quote})), I will get this:

 <?xml version='1.0' encoding='UTF-8' standalone='true'?>
 <root attr1="value1">
   <child attr2="value2"/>
   <child attr3="value3"/>
 </root>

The expected result is:

 <?xml version="1.0" encoding="UTF-8" standalone="true"?>
 <root attr1="value1">
   <child attr2="value2"/>
   <child attr3="value3"/>
 </root>

=end



-- 
http://bugs.ruby-lang.org/