[ruby-core:45391] Re: [RFC] RubyVM::FrameInfo.caller method

Hi,

Thank you for your comment.

(2012/05/29 8:02), Dice wrote:
> I love FrameInfo class! All this time it is that I wanted :-)

Thank you.  I doubt that nobody needs such feature until your response.

>> I think it is strange a bit that the singleton method of the FrameInfo
>> class returns a collection (array) of FrameInfo objects.  And the name
>> `caller()' is confusing with Kernel.caller().
>>
>> Any good name?
>> Or any comment of this new feature?
> 
> I think fit to alter method names as below.
> 
> FrameInfo.caller -> FrameInfo.parse
> 
> 
> If you still think it is strange a bit, there is another one.
> 
> module FrameInfo
> def FrameInfo.parse
> class FrameInfo::Item (or FrameInfo::CallStackItem?)
> def FrameInfo::Item#name
> def FrameInfo::Item#to_s

Other guy pointed out that FrameInfo is to noisy (FooInfo is bad naming
rule).  At last, we change the class name FrameInfo to Location.

> 	* vm_backtrace.c: change names.
> 	  (1) Class name: RubyVM::FrameInfo -> RubyVM::Backtrace::Location.
> 	  (2) Method name: RubyVM::FrameInfo.caller ->
> 	      Kernel.caller_locations.
> 	  (3) Instance methods of
>               RubyVM::FrameInfo (RubyVM::Backtrace::Location)
> 	      (3-1) name -> label
> 	      (3-2) basename -> base_label (basename is confusing with
> 	            File.basename)
> 	      (3-3) line_no -> lineno (We have already similar name
> 	            File#lineno, commented by kou [ruby-dev:45686]).
> 	      (3-4) filename -> path.
> 	      (3-5) filepath -> absolute_path.
> 	      (3-5) iseq -> removed (we will make other APIs to access iseq
> 	            and other information of frame for debugging).

What do you think about it?

-- 
// SASADA Koichi at atdot dot net