From: Yehuda Katz <wycats@...>
Date: 2011-11-14T07:52:38+09:00
Subject: [ruby-core:40998] Re: [Backport93 - Backport #5621] Please backport thread-safe autoloading patch

--20cf300e4bf3338ac604b1a59c9c
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable

We don't use autoload for one simple reason: we support nested autoloads
and don't know ahead of time whether an intermediate module is a module or
class. Consider the following file structure:

|-app
| |-models
| | |-admin
| | | |-user.rb

At various times, I have tried to have Rails' internal structure operate by
setting up autoloads ahead of time and letting Ruby do the rest.
Unfortunately, in this case, we would have to explicitly define Admin, but
we have no way to know whether Admin is a module or class. If we define it
as a module, for instance, and user.rb looks like this:

class Admin
  class User < ActiveRecord::Base
    =85
  end
end

we get: "Admin is not a class". As a result, cannot set everything up ahead
of time and have to let the first file that is autoloaded define the
intermediate namespaces.

--- ASIDE ---

While we're on the topic, http://redmine.ruby-lang.org/issues/2740 is
probably the major remaining issue with Rails' autoload solution. To
summarize:

module Foo
  def self.const_missing(id)
    return lookup(id) if can_lookup?(id)
    raise NoConstantError
  end

  module Bar
    def self.const_missing(id)
      return lookup(id) if can_lookup?(id)
      raise NoConstantError
    end
  end
end

The reason this is needed is that this:

module Foo
  module Bar
    Baz
  end
end

has different semantics than:

module Foo::Bar
  Baz
end

Rails can't tell the difference between these two cases, and therefore
guesses that it's *probably* the first case. But consider this situation:

# foo/array.rb
module Foo
  class Array
  end
end

module Foo::Bar
  Array
end

Because we can't tell from the const_missing call that the nesting is
[Foo::Bar], we assume it's [Foo::Bar, Foo] and load in foo/array.rb even
though that is not the semantically correct behavior. In 99% of cases, this
does not cause any problems, but when it fails (for this and other
reasons), it causes pretty extreme confusion.

Yehuda Katz
(ph) 718.877.1325


On Sun, Nov 13, 2011 at 8:00 AM, Aaron Patterson
<tenderlove@ruby-lang.org>wrote:

> On Sun, Nov 13, 2011 at 10:35:42AM +0900, Hiroshi Nakamura wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > (2011/11/13 1:58), Mike Perham wrote:
> > > My use case: I want to use Rails in thread-safe mode in production
> > > so I don't have to fork 20 Ruby processes to handle 20 concurrent
> > > requests.  When developing, Rails auto loads classes on every
> > > request.  This auto loading is critical to Rails' rapid development
> > > cycle and there's no way I'm going to disable it.  Unfortunately
> > > the current autoload behavior makes the development environment
> > > incompatible with thread-safe mode.
> >
> > I should read ActiveSupport source code first but please allow me to
> > post lazy question.  Does Rails development mode use autoload?  It is
> > doing constant lookup by itself I guess, but I could be wrong, of cours=
e.
>
> ActiveSupport doesn't use autoload for loading missing constants, but
> supporting libraries definitely use autoloading things.  It's quite
> possible that files loaded using the missing constant hooks contain
> autoload directives.  :(
>
> --
> Aaron Patterson
> http://tenderlovemaking.com/
>

--20cf300e4bf3338ac604b1a59c9c
Content-Type: text/html; charset=windows-1252
Content-Transfer-Encoding: quoted-printable

<div>We don&#39;t use autoload for one simple reason: we support nested aut=
oloads and don&#39;t know ahead of time whether an intermediate module is a=
 module or class. Consider the following file structure:</div><div><br></di=
v>

<div>|-app</div><div>| |-models</div><div>| | |-admin</div><div>| | | |-use=
r.rb</div><div><br></div><div>At various times, I have tried to have Rails&=
#39; internal structure operate by setting up autoloads ahead of time and l=
etting Ruby do the rest. Unfortunately, in this case, we would have to expl=
icitly define Admin, but we have no way to know whether Admin is a module o=
r class. If we define it as a module, for instance, and user.rb looks like =
this:</div>

<div><br></div><div>class Admin</div><div>=A0 class User &lt; ActiveRecord:=
:Base</div><div>=A0 =A0 =85</div><div>=A0 end</div><div>end</div><div><br><=
/div><div>we get: &quot;Admin is not a class&quot;. As a result, cannot set=
 everything up ahead of time and have to let the first file that is autoloa=
ded define the intermediate namespaces.</div>

<div><br></div><div>--- ASIDE ---</div><div><br></div><div>While we&#39;re =
on the topic,=A0<a href=3D"http://redmine.ruby-lang.org/issues/2740">http:/=
/redmine.ruby-lang.org/issues/2740</a>=A0is probably the major remaining is=
sue with Rails&#39; autoload solution. To summarize:</div>

<div><br></div><div>module Foo</div><div>=A0 def self.const_missing(id)</di=
v><div>=A0 =A0 return lookup(id) if can_lookup?(id)</div><div>=A0 =A0 raise=
 NoConstantError</div><div>=A0 end</div><div><br></div><div>=A0 module Bar<=
/div><div>

<div>=A0 =A0 def self.const_missing(id)</div><div>=A0 =A0 =A0 return lookup=
(id) if can_lookup?(id)</div><div>=A0 =A0 =A0 raise NoConstantError</div><d=
iv>=A0 =A0 end</div></div><div>=A0 end</div><div>end</div><div><br></div><d=
iv>The reason this is needed is that this:</div>

<div><br></div><div>module Foo</div><div>=A0 module Bar</div><div>=A0 =A0 B=
az</div><div>=A0 end</div><div>end</div><div><br></div><div>has different s=
emantics than:</div><div><br></div><div>module Foo::Bar</div><div>=A0 Baz</=
div><div>

end</div><div><br></div><div>Rails can&#39;t tell the difference between th=
ese two cases, and therefore guesses that it&#39;s *probably* the first cas=
e. But consider this situation:</div><div><br></div><div># foo/array.rb</di=
v>

<div>module Foo</div><div>=A0 class Array</div><div>=A0 end</div><div>end</=
div><div><br></div><div>module Foo::Bar</div><div>=A0 Array</div><div>end</=
div><div><br></div><div>Because we can&#39;t tell from the const_missing ca=
ll that the nesting is [Foo::Bar], we assume it&#39;s [Foo::Bar, Foo] and l=
oad in foo/array.rb even though that is not the semantically correct behavi=
or. In 99% of cases, this does not cause any problems, but when it fails (f=
or this and other reasons), it causes pretty extreme confusion.</div>

<br clear=3D"all">Yehuda Katz<br>(ph) 718.877.1325<br>
<br><br><div class=3D"gmail_quote">On Sun, Nov 13, 2011 at 8:00 AM, Aaron P=
atterson <span dir=3D"ltr">&lt;<a href=3D"mailto:tenderlove@ruby-lang.org">=
tenderlove@ruby-lang.org</a>&gt;</span> wrote:<br><blockquote class=3D"gmai=
l_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left=
:1ex;">

<div class=3D"im">On Sun, Nov 13, 2011 at 10:35:42AM +0900, Hiroshi Nakamur=
a wrote:<br>
&gt; -----BEGIN PGP SIGNED MESSAGE-----<br>
&gt; Hash: SHA1<br>
&gt;<br>
&gt; (2011/11/13 1:58), Mike Perham wrote:<br>
&gt; &gt; My use case: I want to use Rails in thread-safe mode in productio=
n<br>
&gt; &gt; so I don&#39;t have to fork 20 Ruby processes to handle 20 concur=
rent<br>
&gt; &gt; requests. =A0When developing, Rails auto loads classes on every<b=
r>
&gt; &gt; request. =A0This auto loading is critical to Rails&#39; rapid dev=
elopment<br>
&gt; &gt; cycle and there&#39;s no way I&#39;m going to disable it. =A0Unfo=
rtunately<br>
&gt; &gt; the current autoload behavior makes the development environment<b=
r>
&gt; &gt; incompatible with thread-safe mode.<br>
&gt;<br>
&gt; I should read ActiveSupport source code first but please allow me to<b=
r>
&gt; post lazy question. =A0Does Rails development mode use autoload? =A0It=
 is<br>
&gt; doing constant lookup by itself I guess, but I could be wrong, of cour=
se.<br>
<br>
</div>ActiveSupport doesn&#39;t use autoload for loading missing constants,=
 but<br>
supporting libraries definitely use autoloading things. =A0It&#39;s quite<b=
r>
possible that files loaded using the missing constant hooks contain<br>
autoload directives. =A0:(<br>
<span class=3D"HOEnZb"><font color=3D"#888888"><br>
--<br>
Aaron Patterson<br>
<a href=3D"http://tenderlovemaking.com/" target=3D"_blank">http://tenderlov=
emaking.com/</a><br>
</font></span></blockquote></div><br>

--20cf300e4bf3338ac604b1a59c9c--