[#3419] Valgrind analysis of [BUG] unknown node type 0 — Andrew Walrond <andrew@...>

Hello list,

19 messages 2004/09/17
[#3422] Re: Valgrind analysis of [BUG] unknown node type 0 — ts <decoux@...> 2004/09/17

>>>>> "A" == Andrew Walrond <andrew@walrond.org> writes:

[#3423] Re: Valgrind analysis of [BUG] unknown node type 0 — Andrew Walrond <andrew@...> 2004/09/17

On Friday 17 Sep 2004 12:01, ts wrote:

[#3424] Re: Valgrind analysis of [BUG] unknown node type 0 — ts <decoux@...> 2004/09/17

>>>>> "A" == Andrew Walrond <andrew@walrond.org> writes:

[#3425] Re: Valgrind analysis of [BUG] unknown node type 0 — Andrew Walrond <andrew@...> 2004/09/17

On Friday 17 Sep 2004 12:37, ts wrote:

[#3426] Re: Valgrind analysis of [BUG] unknown node type 0 — ts <decoux@...> 2004/09/17

>>>>> "A" == Andrew Walrond <andrew@walrond.org> writes:

[#3428] Re: Valgrind analysis of [BUG] unknown node type 0 — Andrew Walrond <andrew@...> 2004/09/17

On Friday 17 Sep 2004 13:05, ts wrote:

[#3429] Re: Valgrind analysis of [BUG] unknown node type 0 — ts <decoux@...> 2004/09/17

>>>>> "A" == Andrew Walrond <andrew@walrond.org> writes:

REXML's Shift_JIS handling is not good

From: Kouhei Sutou <kou@...>
Date: 2004-09-26 10:04:59 UTC
List: ruby-core #3464
Hi,

REXML's Shift_JIS handling is not good when Iconv doesn't
exist and Uconv exists.

----
Index: lib/rexml/encodings/SHIFT-JIS.rb
===================================================================
RCS file: /var/cvs/src/ruby/lib/rexml/encodings/SHIFT-JIS.rb,v
retrieving revision 1.2
diff -u -p -r1.2 SHIFT-JIS.rb
--- lib/rexml/encodings/SHIFT-JIS.rb    12 Dec 2003 21:17:41 -0000      1.2
+++ lib/rexml/encodings/SHIFT-JIS.rb    26 Sep 2004 09:57:07 -0000
@@ -21,11 +21,11 @@ rescue LoadError
     module REXML
       module Encoding
         @@__REXML_encoding_methods =<<-EOL
-        def to_shift_jis content
+        def encode(content)
           Uconv::u8tosjis(content)
         end

-        def from_shift_jis(str)
+        def decode(str)
           Uconv::sjistou8(str)
         end
         EOL

----

And rexml/encodings/SHIFT-JIS.rb should use `load' instead of
`require'.

----
Index: lib/rexml/encodings/SHIFT_JIS.rb
===================================================================
RCS file: /var/cvs/src/ruby/lib/rexml/encodings/SHIFT_JIS.rb,v
retrieving revision 1.5
diff -u -p -r1.5 SHIFT_JIS.rb
--- lib/rexml/encodings/SHIFT_JIS.rb    2 Apr 2004 03:53:58 -0000       1.5
+++ lib/rexml/encodings/SHIFT_JIS.rb    26 Sep 2004 09:59:36 -0000
@@ -1 +1 @@
-require 'rexml/encodings/Shift-JIS'
+load 'rexml/encodings/SHIFT-JIS.rb'
----


I suggest that rexml/encodings/SHIFT-JIS.rb is
moved to rexml/encodings/SHIFT_JIS.rb and
rexml/encodings/SHIFT-JIS.rb is removed. Because Shift-JIS
doesn't exist in IANA. (Shift_JIS exists in IANA.)

--
kou

In This Thread

Prev Next