From: Johan Holmberg <holmberg@...>
Date: 2004-09-19T21:06:17+09:00
Subject: Re: [PATCH] dir.c (II)


On Sat, 18 Sep 2004, Yukihiro Matsumoto wrote:
>
> In message "Johan Holmberg <holmberg@iar.se>"
>     on Sat, 18 Sep 2004 07:19:18 +0900, nil writes:
>
[...]
> |2) the memory leak that was mentioned in the previous thread doesn't
> |   seem to have been fixed in the change commited today.
> |
[...]
> |
> |I hope the change can be useful.
>
> It's useful.  Thank you.
>
> 							matz.

The commit done yesterday still have the memory leak
in the the following expression

    rb_str_new2(my_getcwd())

Would it be wrong to use "dir_s_getwd(rb_cDir)" now that the code
is rewritten to use VALUEs? That function seems to do the right
thing (including a call to "free").

I also noted that the change was only applied on the "ruby_1_8"
branch.

/Johan Holmberg