[#3419] Valgrind analysis of [BUG] unknown node type 0 — Andrew Walrond <andrew@...>

Hello list,

19 messages 2004/09/17
[#3422] Re: Valgrind analysis of [BUG] unknown node type 0 — ts <decoux@...> 2004/09/17

>>>>> "A" == Andrew Walrond <andrew@walrond.org> writes:

[#3423] Re: Valgrind analysis of [BUG] unknown node type 0 — Andrew Walrond <andrew@...> 2004/09/17

On Friday 17 Sep 2004 12:01, ts wrote:

[#3424] Re: Valgrind analysis of [BUG] unknown node type 0 — ts <decoux@...> 2004/09/17

>>>>> "A" == Andrew Walrond <andrew@walrond.org> writes:

[#3425] Re: Valgrind analysis of [BUG] unknown node type 0 — Andrew Walrond <andrew@...> 2004/09/17

On Friday 17 Sep 2004 12:37, ts wrote:

[#3426] Re: Valgrind analysis of [BUG] unknown node type 0 — ts <decoux@...> 2004/09/17

>>>>> "A" == Andrew Walrond <andrew@walrond.org> writes:

[#3428] Re: Valgrind analysis of [BUG] unknown node type 0 — Andrew Walrond <andrew@...> 2004/09/17

On Friday 17 Sep 2004 13:05, ts wrote:

[#3429] Re: Valgrind analysis of [BUG] unknown node type 0 — ts <decoux@...> 2004/09/17

>>>>> "A" == Andrew Walrond <andrew@walrond.org> writes:

Re: [PATCH] dir.c (II)

From: Johan Holmberg <holmberg@...>
Date: 2004-09-19 12:06:17 UTC
List: ruby-core #3454
On Sat, 18 Sep 2004, Yukihiro Matsumoto wrote:
>
> In message "Johan Holmberg <holmberg@iar.se>"
>     on Sat, 18 Sep 2004 07:19:18 +0900, nil writes:
>
[...]
> |2) the memory leak that was mentioned in the previous thread doesn't
> |   seem to have been fixed in the change commited today.
> |
[...]
> |
> |I hope the change can be useful.
>
> It's useful.  Thank you.
>
> 							matz.

The commit done yesterday still have the memory leak
in the the following expression

    rb_str_new2(my_getcwd())

Would it be wrong to use "dir_s_getwd(rb_cDir)" now that the code
is rewritten to use VALUEs? That function seems to do the right
thing (including a call to "free").

I also noted that the change was only applied on the "ruby_1_8"
branch.

/Johan Holmberg


In This Thread