[#49078] DevelopersMeeting20150728Japan — SASADA Koichi <ko1@...>
Hi,
5 messages
2015/06/12
[ruby-dev:49090] [Ruby trunk - Bug #10852] [Closed] TestObjSpace#test_dump_flags sometimes fails on mswin-CI
From:
ko1@...
Date:
2015-06-16 08:43:00 UTC
List:
ruby-dev #49090
Issue #10852 has been updated by Koichi Sasada.
Status changed from Assigned to Closed
r50914 で trunk は修正しました(ref 忘れた)。
以下は、2.2 向けです。
```diff
Index: ChangeLog
===================================================================
--- ChangeLog (revision 50914)
+++ ChangeLog (working copy)
@@ -1,3 +1,8 @@
+Tue Jun 16 17:39:41 2015 Koichi Sasada <ko1@atdot.net>
+
+ * test/objspace/test_objspace.rb (test_dump_flags): relax pattern
+ because long_lived flag and marked flag can be false at major GC.
+
Mon Jun 15 03:24:23 2015 Koichi Sasada <ko1@atdot.net>
* vm_insnhelper.c (lep_svar_set): add WBs.
Index: test/objspace/test_objspace.rb
===================================================================
--- test/objspace/test_objspace.rb (revision 50914)
+++ test/objspace/test_objspace.rb (working copy)
@@ -196,7 +196,7 @@
def test_dump_flags
info = ObjectSpace.dump("foo".freeze)
- assert_match /"wb_protected":true, "old":true, "long_lived":true, "marked":true/, info
+ assert_match /"wb_protected":true, "old":true/, info
assert_match /"fstring":true/, info
end
```
----------------------------------------
Bug #10852: TestObjSpace#test_dump_flags sometimes fails on mswin-CI
https://bugs.ruby-lang.org/issues/10852#change-52945
* Author: Usaku NAKAMURA
* Status: Closed
* Priority: Normal
* Assignee: Koichi Sasada
* ruby -v: trunk
* Backport: 2.0.0: DONTNEED, 2.1: DONTNEED, 2.2: REQUIRED
----------------------------------------
mswinのCIで、以下のfailureが時々(2割くらい?)出るのですが、何がまずいのでしょうか?
2.2だと頻度はぐっと下がりますが、出ないわけではないようです。
'''
1) Failure:
TestObjSpace#test_dump_flags [D:/tmp/mswin-build20150213-6324-8fqgzk/ruby/test/objspace/test_objspace.rb:199]:
Expected /"wb_protected":true, "old":true, "long_lived":true, "marked":true/ to match "{\"address\":\"0x00000001f5cfe8\", \"type\":\"STRING\", \"class\":\"0x00000000db8ee0\", \"frozen\":true, \"embedded\":true, \"fstring\":true, \"bytesize\":3, \"value\":\"foo\", \"encoding\":\"UTF-8\", \"memsize\":40, \"flags\":{\"wb_protected\":true, \"old\":true}}\n".
'''
--
https://bugs.ruby-lang.org/