ruby-dev

Bug #4419: ext/openssl のコメントが正しくない
http://redmine.ruby-lang.org/issues/show/4419

起票者: Ippei Obayashi
ステータス: Open, 優先度: Low
ruby -v: ruby 1.9.2p180 (2011-02-18 revision 30909) [x86_64-linux]

ext/openssl でいくつかコメントが間違っていると思われる所があるのでパッチを添付します。


----------------------------------------
http://redmine.ruby-lang.org

Attachments (2)

ssl_cipher_doc.patch (512 Bytes, text/x-diff)

diff --git a/ext/openssl/lib/openssl/cipher.rb b/ext/openssl/lib/openssl/cipher.rb
index 290e9c1..279e3b7 100644
--- a/ext/openssl/lib/openssl/cipher.rb
+++ b/ext/openssl/lib/openssl/cipher.rb
@@ -57,7 +57,7 @@ module OpenSSL
       return str
     end
 
-    # This class is only provided for backwards compatibility.  Use OpenSSL::Digest in the future.
+    # This class is only provided for backwards compatibility.  Use OpenSSL::Cipher in the future.
     class Cipher < Cipher
       # add warning
     end

ssl_rdoc.patch (852 Bytes, text/x-diff)

diff --git a/ext/openssl/ossl_cipher.c b/ext/openssl/ossl_cipher.c
index c164b8b..c723b15 100644
--- a/ext/openssl/ossl_cipher.c
+++ b/ext/openssl/ossl_cipher.c
@@ -444,7 +444,7 @@ ossl_cipher_set_iv(VALUE self, VALUE iv)
 
 /*
  *  call-seq:
- *     cipher.key_length = integer -> integer
+ *     cipher.key_len = integer -> integer
  *
  *  Sets the key length of the cipher.  If the cipher is a fixed length cipher then attempting to set the key
  *  length to any value other than the fixed value is an error.
@@ -507,13 +507,13 @@ CIPHER_0ARG_INT(block_size)
 #if 0
 /*
  *  call-seq:
- *     cipher.key_length -> integer
+ *     cipher.key_len -> integer
  *
  */
 static VALUE ossl_cipher_key_length() { }
 /*
  *  call-seq:
- *     cipher.iv_length -> integer
+ *     cipher.iv_len -> integer
  *
  */
 static VALUE ossl_cipher_iv_length() { }

Thread

Prev Next

In This Thread

Prev Next

[#43167] Re: [ruby-cvs:37950] Ruby:r30760 (trunk): Import RDoc 3.5.1 — "NARUSE, Yui" <naruse@...>

[#43168] [Ruby 1.9-Bug#4361][Open] SCRIPT_LINES__ mechanism should treat magic-comment. — Kyosuke MOROHASHI <redmine@...>

[#43169] [Ruby 1.9-Bug#4362][Open] Process.kill should accept -SIGXXX with implicit conversion — Tomoyuki Chikanaga <redmine@...>

[#43170] [Ruby 1.9-Bug#4366][Open] UTF-8文字列に対しての部分文字列取得操作で結果にゴミがつくことがある — Motohiro KOSAKI <redmine@...>

[#43174] [Ruby 1.9-Bug#4371][Open] assert_blockで ArgumentError が起きます — Motohiro KOSAKI <redmine@...>

[#43178] [Backport92-Backport#4377][Open] popen("-") で、乱数が初期化されない — Motohiro KOSAKI <redmine@...>

[#43179] [Ruby 1.9-Bug#4378][Open] 1.9.2でClassオブジェクトのcloneの特異メソッドが消える — yasuo tone <redmine@...>

[#43181] [Ruby 1.9-Bug#4387][Open] test_socket_connect_nonblock(TestSocketAddrinfo) がまれに失敗する — Motohiro KOSAKI <redmine@...>

[#43186] [Ruby 1.9-Bug#4388][Open] open-uriで環境変数http_proxyを使うときに認証付きのProxyが使えません — あつし よしだ <redmine@...>

[#43199] Re: [ruby-changes:18827] Ruby:r30852 (trunk): * thread.c (rb_thread_io_blocking_region): new function to run — SASADA Koichi <ko1@...>

[#43201] [Ruby 1.9-Bug#4395][Assigned] Can't require test/rubygems/simple_gem when tests run in different directory — Yui NARUSE <redmine@...>

[#43203] [Ruby 1.9-Bug#4397][Open] test-mkmf fails due to compilation errors — Shyouhei Urabe <redmine@...>

[#43213] rb_mutex_try_lock in intern.h — keiju@... (Keiju ISHITSUKA)

[#43214] hook するイベントの種類 — SASADA Koichi <ko1@...>

[#43215] OSXでsigpipe処理中にSEGVする事が多い? — "Shota Fukumori (sora_h)" <sorah@...>

[#43222] Rubyのtest-allを並列化するパッチを書きました — "Shota Fukumori (sora_h)" <sorah@...>

[#43226] [Ruby 1.9-Feature#4415][Open] Rubyのtest-allを並列化するパッチが完成しました — Shota Fukumori <redmine@...>

[#43233] [Ruby 1.9-Bug#4416][Open] OpenSSL::SSL::Session#session_new_cb — Ippei Obayashi <redmine@...>

[#43234] [Ruby 1.9-Bug#4417][Open] OpenSSL::Buffering#each_byte がブロックに文字をStringで渡している — Ippei Obayashi <redmine@...>

[#43235] [Ruby 1.9-Bug#4418][Open] OpenSSL::PKey::DH#public_key — Ippei Obayashi <redmine@...>

[#43236] [Ruby 1.9-Bug#4419][Open] ext/openssl のコメントが正しくない — Ippei Obayashi <redmine@...>

[#43237] [Ruby 1.9-Bug#4420][Open] OpenSSL::X509::Request#to_der で RequestError ではなく CertificateError が発生する — Ippei Obayashi <redmine@...>

[#43241] [ANN] redmine.ruby-lang.orgメンテナンスのお知らせ — "Yuki Sonoda (Yugui)" <yugui@...>

[#43245] lib/test/*のメンテナに立候補します。 — "Shota Fukumori (sora_h)" <sorah@...>

[#43252] [Ruby 1.9 - Bug #4429] (Open) test — Yuki Sonoda <yugui@...>

[#43253] [Ruby 1.9 - Bug #4430] (Open) 新型redmine.ruby-lang.orgのテスト — Yuki Sonoda <yugui@...>

[#43257] [Bug:1.9] redmine.ruby-lang.org更改のためのテスト送信 — Yugui <yugui@...>

[#43258] redmine.ruby-lang.org更改のためのテスト送信 — Yugui <yugui@...>

[#43259] [Ruby 1.9 - Backport #4432] (Closed) redmine.ruby-lang.org更改のためのテスト送信 — Yuki Sonoda <yugui@...>

[#43260] [Ruby 1.9 - Bug #4431] (Closed) redmine.ruby-lang.org更改のためのテスト送信 — Yuki Sonoda <yugui@...>

[#43264] [Ruby 1.9 - Bug #4434] [Assigned] make test-all "-j10000" のように大きな並列数を与えると異常終了 — Motohiro KOSAKI <kosaki.motohiro@...>

[#43270] [Ruby 1.9 - Bug #4439] [Assigned] TestBeginEndBlock#test_should_propagate_signaled が必ず1度失敗する — Motohiro KOSAKI <kosaki.motohiro@...>

[#43271] [Ruby 1.9 - Bug #4441] [Closed] test — Usaku NAKAMURA <redmine@...>

[#43272] [Ruby 1.9 - Bug #4443] [Open] odd evaluation order in a multiple assignment — Yusuke Endoh <mame@...>

[#43273] [Ruby 1.9 - Bug #4444] [Assigned] Windowsプラットフォームでtest_parallel.rbがエラー — Motohiro KOSAKI <kosaki.motohiro@...>

[#43274] [Ruby 1.9 - Bug #4445] [Open] ext/openssl の verify_callback が rb_protect で保護されていない — Ippei Obayashi <ohai@...>

[#43276] iseq_compile_each()でのマジックナンバ — きたざわけんいち <peisunstar@...>

[#43278] ci.ruby-lang.org — Shugo Maeda <shugo@...>

[ruby-dev:43236] [Ruby 1.9-Bug#4419][Open] ext/openssl のコメントが正しくない

Attachments (2)

Thread

In This Thread

[#43186] [Ruby 1.9-Bug#4388][Open] open-uriで環境変数http_proxyを使うときに認証付きのProxyが使えません — あつしよしだ <redmine@...>