ruby-dev

Bug #4024: IO#readlines(0) never return
http://redmine.ruby-lang.org/issues/show/4024

起票者: Tomoyuki Chikanaga
ステータス: Open, 優先度: Normal
カテゴリ: core
ruby -v: ruby 1.9.3dev (2010-11-04 trunk 29690) [x86_64-darwin10.4.0]

1.9.2 および trunk で IO#readlines の引数に 0 を渡すと無限ループ状態になり処理がかえってこなくなります。
IO#each_line も同様に "" を yield し続けます。
(via http://twitter.com/#!/watson1978/status/29656929210)

readlines/each_line で limit に 0 が渡された時は例外にするのが良いのではないでしょうか。
パッチを添付します。


----------------------------------------
http://redmine.ruby-lang.org

Attachments (1)

io_readlines.patch (1.35 KB, text/x-diff)

Index: io.c
===================================================================
--- io.c	(revision 29690)
+++ io.c	(working copy)
@@ -2724,6 +2724,8 @@
     long limit;
 
     prepare_getline_args(argc, argv, &rs, &limit, io);
+    if (limit == 0) 
+	rb_raise(rb_eArgError, "invalid limit: 0 for readlines");
     ary = rb_ary_new();
     while (!NIL_P(line = rb_io_getline_1(rs, limit, io))) {
 	rb_ary_push(ary, line);
@@ -2773,6 +2775,8 @@
 
     RETURN_ENUMERATOR(io, argc, argv);
     prepare_getline_args(argc, argv, &rs, &limit, io);
+    if (limit == 0) 
+	rb_raise(rb_eArgError, "invalid limit: 0 for each_line");
     while (!NIL_P(str = rb_io_getline_1(rs, limit, io))) {
 	rb_yield(str);
     }
Index: test/ruby/test_io.rb
===================================================================
--- test/ruby/test_io.rb	(revision 29690)
+++ test/ruby/test_io.rb	(working copy)
@@ -1702,4 +1702,24 @@
       GC.start
     end
   end
+
+  def test_readlines_limit_0
+    bugxxx = "[ruby-dev:xxx]"
+    t = make_tempfile
+    assert_raise(ArgumentError, bugxxx) do
+      open(t.path, "r") do |io|
+        io.readlines(0)
+      end
+    end
+  end
+
+  def test_each_line_limit_0
+    bugxxx = "[ruby-dev:xxx]"
+    t = make_tempfile
+    assert_raise(ArgumentError, bugxxx) do
+      open(t.path, "r") do |io|
+        io.each_line(0).next
+      end
+    end
+  end
 end

Thread

Prev Next

In This Thread

Prev Next

[#42508] [Ruby 1.9-Bug#4013][Open] rake/test_tasks.rb fails if ENV assined test value — Akio Tajima <redmine@...>

[#42509] memory usage of test-all — SASADA Koichi <ko1@...>

[#42520] GC issues — SASADA Koichi <ko1@...>

[#42522] Proposal: thread local freelist — SASADA Koichi <ko1@...>

[#42523] [Ruby 1.9-Bug#4019][Open] root fiber allows double resume — Yusuke Endoh <redmine@...>

[#42524] [Ruby 1.9-Bug#4020][Open] Fiber#initialize causes memory leaks — Yusuke Endoh <redmine@...>

[#42527] Finalizer behaviour — SASADA Koichi <ko1@...>

[#42538] [Ruby 1.9-Bug#4024][Open] IO#readlines(0) never return — Tomoyuki Chikanaga <redmine@...>

[#42540] [Ruby 1.9-Bug#4027][Open] Signal.trap で busy loop に陥る — Tomoyuki Chikanaga <redmine@...>

[#42541] [Ruby 1.9-Bug#4027] Signal.trap で busy loop に陥る — Tomoyuki Chikanaga <redmine@...>

[#42545] [Ruby 1.9-Bug#4027] Signal.trap で busy loop に陥る — Tomoyuki Chikanaga <redmine@...>

[#42546] [Ruby 1.9-Bug#4033][Open] Segmentation fault : ext/openssl:OpenSSL::X509::StoreContext#cleanup — Ippei Obayashi <redmine@...>

[#42550] [Ruby 1.9-Bug#3674] dRuby サーバプロセスを停止する時に時間がかかることがある — Yui NARUSE <redmine@...>

[#42551] [Ruby 1.9-Bug#4034][Open] format() の %a 指定子での丸めが常に零方向になっている — tadayoshi funaba <redmine@...>

[#42552] [Ruby 1.9-Bug#4035][Open] format() の %a 指定子で幅指定が正しく機能しないことがある — tadayoshi funaba <redmine@...>

[#42560] [Ruby 1.9-Bug#4027] Signal.trap で busy loop に陥る — Tomoyuki Chikanaga <redmine@...>

[#42561] [Ruby 1.9-Bug#4027] Signal.trap で busy loop に陥る — Tomoyuki Chikanaga <redmine@...>

[#42563] [Ruby 1.9-Bug#4027] Signal.trap で busy loop に陥る — Tomoyuki Chikanaga <redmine@...>

[#42564] [Ruby 1.9-Feature#4043][Open] グローバル関数current_classの提案 — Makoto Kishimoto <redmine@...>

[#42565] r29741 以降 Mac OS X 10.6 でビルド失敗 — nagachika <nagachika00@...>

[#42567] [Ruby 1.9-Bug#4045][Assigned] build error on mswin — Usaku NAKAMURA <redmine@...>

[#42573] [Ruby 1.9-Bug#4055][Open] segfault in OpenSSL::SSLSocket#cert — Ippei Obayashi <redmine@...>

[#42575] Fwd: Modules twice — SASADA Koichi <ko1@...>

[#42577] Rubyのバグレポートのガイドライン — "Shota Fukumori (sora_h)" <sorah@...>

[#42578] [Ruby 1.9-Bug#3674] dRuby サーバプロセスを停止する時に時間がかかることがある — Tomoyuki Chikanaga <redmine@...>

[#42579] [Ruby 1.9-Bug#4061][Open] char class may cause memory leak — Yusuke Endoh <redmine@...>

[#42583] [Ruby 1.8-Backport#3954] Digest::Base に無引数の initialize を定義しませんか？ — Shyouhei Urabe <redmine@...>

[#42584] [Ruby 1.8-Backport#3954] Digest::Base に無引数の initialize を定義しませんか？ — Akinori MUSHA <redmine@...>

[#42585] [Ruby 1.8-Backport#3954][Assigned] Digest::Base に無引数の initialize を定義しませんか？ — Akinori MUSHA <redmine@...>

[#42586] [Ruby 1.9-Backport#3954] Digest::Base に無引数の initialize を定義しませんか？ — Shyouhei Urabe <redmine@...>

[#42599] Re: [ruby-cvs:37021] Ruby:r29827 (trunk): * lib/rexml/formatters/pretty.rb (REXML::Formatters::Pretty#wrap): — "NARUSE, Yui" <naruse@...>

[#42601] [Ruby 1.9-Bug#4072][Open] dRubyで作成したサーバプログラムがsleepしていてもexitしてしまう — 三村 益隆 <redmine@...>

[#42615] [Ruby 1.9-Bug#4078][Open] format() の %a 指定で 不要な小数点が印字されることがある — tadayoshi funaba <redmine@...>

[#42622] JIS意見受付公告 — Shugo Maeda <shugo@...>

[#42624] Planning to release 1.8.7 fixes on 12/25 (Japanese timezone) — Urabe Shyouhei <shyouhei@...>

[#42625] [Ruby 1.9-Feature#4089][Open] Add addr2line for C level backtrace — Yui NARUSE <redmine@...>

[#42631] [Ruby 1.9-Bug#4090][Open] Time::new に時差を与えたとき、正しい日付が得られない事がある — tadayoshi funaba <redmine@...>

[#42633] [Ruby 1.9-Bug#4092] r29946 でビルドが通らない — Shota Fukumori <redmine@...>

[#42634] [Ruby 1.9-Bug#4092][Open] r29946 でビルドが通らない — Shota Fukumori <redmine@...>

[#42638] Enumerable#categorize — Tanaka Akira <akr@...>

[#42655] [Ruby 1.9-Feature#4096][Open] Follow .gnu_debuglink section. — Shinichiro Hamaji <redmine@...>

[#42656] [Request for Comment] avoid timer thread — SASADA Koichi <ko1@...>

[#42661] (mswin32) fix port used in test/socket — arton <artonx@...>

[ruby-dev:42538] [Ruby 1.9-Bug#4024][Open] IO#readlines(0) never return

Attachments (1)

Thread

In This Thread

[#42601] [Ruby 1.9-Bug#4072][Open] dRubyで作成したサーバプログラムがsleepしていてもexitしてしまう — 三村益隆 <redmine@...>

[#42615] [Ruby 1.9-Bug#4078][Open] format() の %a 指定で不要な小数点が印字されることがある — tadayoshi funaba <redmine@...>