ruby-dev

1.8.2-preview1での問題ではありませんが
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=260779
のようなバグ報告が届きました。

もっともだと思うので、次のような変更を考えてみました。
よければ1.8.2に取り込んでいただきたいです。

Index: lib/cgi/session.rb
===================================================================
RCS file: /var/cvs/src/ruby/lib/cgi/session.rb,v
retrieving revision 1.23.2.3
diff -u -r1.23.2.3 session.rb
--- lib/cgi/session.rb	14 Jul 2004 14:22:11 -0000	1.23.2.3
+++ lib/cgi/session.rb	22 Jul 2004 07:41:54 -0000
@@ -395,7 +395,7 @@
       def update
 	return unless @hash
         begin
-	  f = File.open(@path, 'w')
+	  f = File.open(@path, File::CREAT|File::TRUNC|File::RDWR, 0600)
 	  f.flock File::LOCK_EX
    	  for k,v in @hash
 	    f.printf "%s=%s\n", CGI::escape(k), CGI::escape(String(v))
Index: lib/cgi/session/pstore.rb
===================================================================
RCS file: /var/cvs/src/ruby/lib/cgi/session/pstore.rb,v
retrieving revision 1.3
diff -u -r1.3 pstore.rb
--- lib/cgi/session/pstore.rb	16 Oct 2003 17:47:18 -0000	1.3
+++ lib/cgi/session/pstore.rb	22 Jul 2004 07:41:54 -0000
@@ -70,6 +70,9 @@
 	  @hash = {}
 	end
 	@p = ::PStore.new(path)
+	@p.transaction do |p|
+	  File.chmod(0600, p.path)
+	end
       end

       # Restore session state from the session's PStore file.

# symlinkやownerのチェックも必要でしょうか?

-- 
やまだあきら / akira yamada  <http://arika.org>

Thread

Prev Next

In This Thread

Prev Next

[#23843] st_dev by stat() != st_dev by fstat() in windows — "H.Yamamoto" <ocean@...2.ccsnet.ne.jp>

[#23854] class in singleton class — "NAKAMURA, Hiroshi" <nakahiro@...>

[#23855] Are these comittable? — "H.Yamamoto" <ocean@...2.ccsnet.ne.jp>

[#23859] arguments to Thread.start — nobu.nakada@...

[#23864] avalue and break in C block — nobu.nakada@...

[#23871] syntax error — WATANABE Hirofumi <eban@...>

[#23876] cgi, cgi/session — 堀川 久 <vzw00011@...>

[#23883] [bug] strtod(".") should raise ArgumentError — "H.Yamamoto" <ocean@...2.ccsnet.ne.jp>

[#23884] Ruby 1.8.2 preview1にむけて — matz@... (Yukihiro Matsumoto)

[#23888] super in Method — nobu.nakada@...

[#23891] openssl test failed — MIYAMUKO Katsuyuki <k-miyamuko@...>

[#23922] ruby 1.8.2 preview1 — matz@... (Yukihiro Matsumoto)

[#23946] [mswin32][ruby1.8.2] $?.pid == 0 — Masahiro Kitajima <katonbo@...>

[#23963] bcc32 {f,fd,fs}open — "H.Yamamoto" <ocean@...2.ccsnet.ne.jp>

[#23965] WEBrick::HTTPUtils.escape(" ") — Tanaka Akira <akr@...17n.org>

[#23967] WEBrick::HTTPUtils.escape and URI.escape — Tanaka Akira <akr@...17n.org>

[#23970] ruby_1_8 のバイナリ互換 — "H.Yamamoto" <ocean@...2.ccsnet.ne.jp>

[#23971] typo in inf-ruby.el — Kazuo Saito <ksaito@...>

[#23973] 引数の上書きとsuper — matz@... (Yukihiro Matsumoto)

[#23977] テスト4 — Shugo Maeda <shugo@...>

[#23979] Re: [ruby-cvs] ruby: * eval.c (rb_eval): copy on write for argument local variable — "U.Nakamura" <usa@...>

[#23984] tempfile not removed. — Tanaka Akira <akr@...17n.org>

[#23989] core dump with calling private concat inherited from Array — Tanaka Akira <akr@...17n.org>

[#23991] 1.8.2-preview2? — akira yamada / やまだあきら <akira@...>

[#23995] String#each -> String#each_char — Shugo Maeda <shugo@...>

[#24001] ruby-mode.el のインデント — GOTO Naohisa <ngoto@...>

[#24006] core dump with drb in test — Tanaka Akira <akr@...17n.org>

[ruby-dev:23952] Re: ruby 1.8.2 preview1

Thread

In This Thread

[#23876] cgi, cgi/session — 堀川久 <vzw00011@...>