[ruby-dev:22617] Re: (Time.at(1.1) - 0.2).usec

なかだです。

At Sun, 18 Jan 2004 16:28:45 +0900,
Nobuyoshi-Nakada wrote:
> +#define ADJUST_USEC(sec, usec) (			\
> +    (usec < 0) ? (usec += 1000000, sec--) :		\
> +    (usec >= 1000000) ? (usec -= 1000000, sec++) :	\
> +    0)

じゃなくて、time_overflow_p()が値を返してませんね。


Index: time.c
===================================================================
RCS file: /cvs/ruby/src/ruby/time.c,v
retrieving revision 1.93
diff -u -2 -p -r1.93 time.c
--- time.c	18 Jan 2004 04:11:09 -0000	1.93
+++ time.c	18 Jan 2004 07:39:27 -0000
@@ -113,8 +113,8 @@ time_init(time)
 
 void
-time_overflow_p(sec, usec)
-    time_t sec, usec;
+time_overflow_p(secp, usecp)
+    time_t *secp, *usecp;
 {
-    time_t tmp;
+    time_t tmp, sec = *secp, usec = *usecp;
 
     if (usec >= 1000000) {	/* usec positive overflow */
@@ -138,4 +138,6 @@ time_overflow_p(sec, usec)
 	rb_raise(rb_eArgError, "time must be positive");
 #endif
+    *secp = sec;
+    *usecp = usec;
 }
 
@@ -149,5 +151,5 @@ time_new_internal(klass, sec, usec)
 
     GetTimeval(time, tobj);
-    time_overflow_p(sec, usec);
+    time_overflow_p(&sec, &usec);
     tobj->tv.tv_sec = sec;
     tobj->tv.tv_usec = usec;
@@ -1910,5 +1912,5 @@ time_mload(time, str)
 	usec = (time_t)(s & 0xfffff);
     }
-    time_overflow_p(sec, usec);
+    time_overflow_p(&sec, &usec);
 
     GetTimeval(time, tobj);


-- 
--- 僕の前にBugはない。
--- 僕の後ろにBugはできる。
    中田 伸悦