[ruby-core:94939] [Ruby master Bug#16167] make-snapshot does not work from fresh checkout

From: nobu@...
Date: 2019-09-15 07:23:10 UTC
List: ruby-core #94939
Issue #16167 has been updated by nobu (Nobuyoshi Nakada).


vo.x (Vit Ondruch) wrote:
> So this is in line with the changes referred here, but I somehow fail to see why the refs/notes/commits are not fetched automatically? Why should I do this myself? Previously, the make-snapshot did not need any additional actions.

I wanted to get rid of modifying the source tree.



----------------------------------------
Bug #16167: make-snapshot does not work from fresh checkout
https://bugs.ruby-lang.org/issues/16167#change-81555

* Author: vo.x (Vit Ondruch)
* Status: Assigned
* Priority: Normal
* Assignee: nobu (Nobuyoshi Nakada)
* Target version: 
* ruby -v: ruby 2.6.3p62 (2019-04-16 revision 67580) [x86_64-linux]
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN
----------------------------------------
So far, I was using this sequence to get Ruby snapshot:

~~~
git clone https://github.com/ruby/ruby ~/ruby
cd ~/ruby && tool/make-snapshot -packages=xz -git=https://github.com/ruby/ruby tmp
~~~

But that does not work anymore. It seems I am not supposed to use the -git option anymore. So lets drop it:

~~~
$ tool/make-snapshot -packages=xz ./tmp
Exporting @98f919ed47a136c9a51c7ab5fa39ffb4965a1687
Cloning into '/tmp/ruby-snapshot20190913-95-1lk1fkq/ruby'...
done.
fatal: couldn't find remote ref refs/notes/commits
fatal: the remote end hung up unexpectedly
Traceback (most recent call last):
	6: from tool/make-snapshot:578:in `<main>'
	5: from tool/make-snapshot:578:in `collect'
	4: from tool/make-snapshot:578:in `block in <main>'
	3: from tool/make-snapshot:285:in `package'
	2: from /builddir/ruby/tool/lib/vcs.rb:587:in `export'
	1: from /builddir/ruby/tool/lib/vcs.rb:115:in `system'
/builddir/ruby/tool/lib/vcs.rb:115:in `system': Command failed with exit 128: git (RuntimeError)
~~~

So something is broken.

When I added `-exported=.` option, finally I've got something:

~~~
$ tool/make-snapshot -packages=xz -exported=. tmp
Traceback (most recent call last):
	6: from tool/make-snapshot:578:in `<main>'
	5: from tool/make-snapshot:578:in `collect'
	4: from tool/make-snapshot:578:in `block in <main>'
	3: from tool/make-snapshot:360:in `package'
	2: from tool/make-snapshot:360:in `chdir'
	1: from tool/make-snapshot:362:in `block in package'
/builddir/ruby/tool/lib/vcs.rb:614:in `export_changelog': need notes/commits tree; run `git fetch origin refs/notes/commits:refs/notes/commits` in the repository (RuntimeError)
~~~

Running this command, it helped, but that appears to be less than ideal UX.



-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>

In This Thread

Prev Next