[ruby-core:92718] [Ruby trunk Feature#15861] Correctly parse `file:c:/path/to/file` URIs

Issue #15861 has been updated by phluid61 (Matthew Kerwin).


jeremyevans0 (Jeremy Evans) wrote:
> Looking at RFC 8089, Appendix E (`Nonstandard Syntax Variations`) states: 
> 
> ```
>    These variations may be encountered by existing usages of the file
>    URI scheme but are not supported by the normative syntax of
>    Section 2.
> 
>    This appendix is not normative.
> ```
> 

"may be encountered" here is meant to mean that old "poorly formed" URIs exist in the wild, and occasionally we encounter them.  For example, if I were to write a Ruby script to update a bunch of historical documentation from 1997.  It can also mean the kind of stuff humans input, which "worked for me when I did it in Internet Explorer".

>
> Appendix E.2 says that the following form is already supported: `file:///c:/path/to/file`.  Using that with the URI library:
> 
> ```ruby
> URI.parse("file:///c:/path/to/file").path
> => "/c:/path/to/file"
> ```
> 

In other words, implement a pre-parser that detects E.2-flavoured URIs and inserts the extra slash.  FWIW there's actually a [gem](https://phluid61.github.io/file-uri/) out there that does essentially this, however since it was written and published alongside RFC 8089 it predates the core File URI handling.

```
require 'file-uri/win'
URI.parse("file:c:/path/to/file").path
=> "/c:/path/to/file"
```

> I can see where the preceding `/` may present an issue.  However, I am not sure whether we want to add support for nonstandard syntax variations to the `file` scheme.

It's a pain, but it's a pain we've lived with forever.  FWIW, I added a `#to_file_path` method in that gem to see if it makes this particular paint point any easier.  But I don't think this is the major driver, more it's having to detect and correct those other URIs.

All said; if all else fails there's always Addressable.

----------------------------------------
Feature #15861: Correctly parse `file:c:/path/to/file` URIs
https://bugs.ruby-lang.org/issues/15861#change-78075

* Author: deivid (David Rodr刕uez)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
----------------------------------------
Recently ruby has getting better at parsing URIs using the "file" scheme, with the addition of "URI::File". Still, some Windows edge cases are not implemented, and it would be nice to have them. For example, while the [addressable gem](https://github.com/sporkmonger/addressable) can correct parse "file:c:/path/to/file", the builtin library is not that smart yet:

``` 
irb(main):001:0> URI.parse("file:c:/path/to/file").path
=> nil
irb(main):002:0> require 'addressable'
=> true
irb(main):003:0> Addressable::URI.parse("file:c:/path/to/file").path
=> "c:/path/to/file"
```

I think this would be a matter of implementing https://tools.ietf.org/html/rfc8089#appendix-E.2, which is not normative but it would be certainly nice to have.



-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:[e-mail]?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>