From: nobu@...
Date: 2019-05-23T13:11:30+00:00
Subject: [ruby-core:92797] [Ruby trunk Feature#15868] Implement	`File.absolute_path?`

Issue #15868 has been updated by nobu (Nobuyoshi Nakada).


> ```diff
> +      File.basename("/foo/bar\\baz").should == true

The method name is wrong, and `File.absolute_path?("/foo/bar")` should be false on Windows as it doesn't have the drive letter.

----------------------------------------
Feature #15868: Implement `File.absolute_path?`
https://bugs.ruby-lang.org/issues/15868#change-78171

* Author: deivid (David Rodr�guez)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
----------------------------------------
Currently there's no way to check whether a path is absolute or not in a way that works accross OSs. The pathname library has the #absolute? method, but that only checks whether the path starts with a slash, which is not appropriate for Windows.

I thought of reimplementing it as something like File.absolute_path(self) == self, but that would mean accessing the filesystem, which I don't think we want here.

I also thought of implementing the "windows letter checks" in the pathname's library, but then I saw that those are already implemented in file.c, so I thought it would be a good idea to expose those. So I propose to add File.absolute_path? for this.

If this is accepted, I can do a follow-up PR to change Pathname#absolute? to delegate to File.absolute_path?.

What do you think?

I attach a patch to add `File.absolute_path?` here (I also opened a PR on Github: https://github.com/ruby/ruby/pull/2198). 

---Files--------------------------------
0001-Add-File.absolute_path.patch (3.24 KB)


-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>