[ruby-core:92844] [Ruby trunk Bug#11363] Fix tests for String#crypt so they pass on OpenBSD

From: merch-redmine@...
Date: 2019-05-25 22:45:29 UTC
List: ruby-core #92844
Issue #11363 has been updated by jeremyevans0 (Jeremy Evans).


CI looks clean with https://github.com/ruby/ruby/pull/2200, so I'll be committing it in about a week if there are no objections.

----------------------------------------
Bug #11363: Fix tests for String#crypt so they pass on OpenBSD
https://bugs.ruby-lang.org/issues/11363#change-78225

* Author: jeremyevans0 (Jeremy Evans)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: ruby 2.3.0dev (2015-07-16 openbsd 51261) [x86_64-openbsd]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
The String#crypt documentation states "the format and the result
are system and implementation dependent", so the tests should not
be checking for specific results.  We should only be checking that
the method returns a string, that the results are different
if you use a different password or different salt, and the results
are the same if the using the encypted password as the salt
results in the same encrypted password.

---Files--------------------------------
0001-Fix-tests-for-String-crypt.patch (2.02 KB)


-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>

In This Thread

Prev Next