From: deivid.rodriguez@... Date: 2019-05-23T12:25:01+00:00 Subject: [ruby-core:92796] [Ruby trunk Feature#15868] Implement `File.absolute_path?` Issue #15868 has been updated by deivid (David Rodr�guez). Ouch! I actually read the `Pathname` docs, which state: * "However non-Unix pathnames are supported experimentally", in the main section. * "It returns true if the pathname begins with a slash", in the `#pathname` docs. And assumed this didn't work on Windows. If this is the case, I'm not too strong towards adding `File.absolute_path?` although it still seems handy and simple? ---------------------------------------- Feature #15868: Implement `File.absolute_path?` https://bugs.ruby-lang.org/issues/15868#change-78170 * Author: deivid (David Rodr�guez) * Status: Open * Priority: Normal * Assignee: * Target version: ---------------------------------------- Currently there's no way to check whether a path is absolute or not in a way that works accross OSs. The pathname library has the #absolute? method, but that only checks whether the path starts with a slash, which is not appropriate for Windows. I thought of reimplementing it as something like File.absolute_path(self) == self, but that would mean accessing the filesystem, which I don't think we want here. I also thought of implementing the "windows letter checks" in the pathname's library, but then I saw that those are already implemented in file.c, so I thought it would be a good idea to expose those. So I propose to add File.absolute_path? for this. If this is accepted, I can do a follow-up PR to change Pathname#absolute? to delegate to File.absolute_path?. What do you think? I attach a patch to add `File.absolute_path?` here (I also opened a PR on Github: https://github.com/ruby/ruby/pull/2198). ---Files-------------------------------- 0001-Add-File.absolute_path.patch (3.24 KB) -- https://bugs.ruby-lang.org/ Unsubscribe: